Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Side by Side Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.h

Issue 2639893002: Clean up unneeded JavaScript dialog parameter. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_JAVASCRIPT_DIALOG_HELPER_H_ 5 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_JAVASCRIPT_DIALOG_HELPER_H_
6 #define EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_JAVASCRIPT_DIALOG_HELPER_H_ 6 #define EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_JAVASCRIPT_DIALOG_HELPER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "content/public/browser/javascript_dialog_manager.h" 9 #include "content/public/browser/javascript_dialog_manager.h"
10 10
(...skipping 15 matching lines...) Expand all
26 const base::string16& default_prompt_text, 26 const base::string16& default_prompt_text,
27 const DialogClosedCallback& callback, 27 const DialogClosedCallback& callback,
28 bool* did_suppress_message) override; 28 bool* did_suppress_message) override;
29 void RunBeforeUnloadDialog(content::WebContents* web_contents, 29 void RunBeforeUnloadDialog(content::WebContents* web_contents,
30 bool is_reload, 30 bool is_reload,
31 const DialogClosedCallback& callback) override; 31 const DialogClosedCallback& callback) override;
32 bool HandleJavaScriptDialog(content::WebContents* web_contents, 32 bool HandleJavaScriptDialog(content::WebContents* web_contents,
33 bool accept, 33 bool accept,
34 const base::string16* prompt_override) override; 34 const base::string16* prompt_override) override;
35 void CancelDialogs(content::WebContents* web_contents, 35 void CancelDialogs(content::WebContents* web_contents,
36 bool suppress_callbacks,
37 bool reset_state) override; 36 bool reset_state) override;
38 37
39 private: 38 private:
40 void OnPermissionResponse( 39 void OnPermissionResponse(
41 const DialogClosedCallback& callback, 40 const DialogClosedCallback& callback,
42 bool allow, 41 bool allow,
43 const std::string& user_input); 42 const std::string& user_input);
44 43
45 // Pointer to the webview that is being helped. 44 // Pointer to the webview that is being helped.
46 WebViewGuest* const web_view_guest_; 45 WebViewGuest* const web_view_guest_;
47 46
48 DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogHelper); 47 DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogHelper);
49 }; 48 };
50 49
51 } // namespace extensions 50 } // namespace extensions
52 51
53 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_JAVASCRIPT_DIALOG_HELPER_H_ 52 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_JAVASCRIPT_DIALOG_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698