Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2639893002: Clean up unneeded JavaScript dialog parameter. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <utility> 6 #include <utility>
7 7
8 #include "base/base64.h" 8 #include "base/base64.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 bool is_reload, 112 bool is_reload,
113 const DialogClosedCallback& callback) override {} 113 const DialogClosedCallback& callback) override {}
114 114
115 bool HandleJavaScriptDialog(WebContents* web_contents, 115 bool HandleJavaScriptDialog(WebContents* web_contents,
116 bool accept, 116 bool accept,
117 const base::string16* prompt_override) override { 117 const base::string16* prompt_override) override {
118 return true; 118 return true;
119 } 119 }
120 120
121 void CancelDialogs(WebContents* web_contents, 121 void CancelDialogs(WebContents* web_contents,
122 bool suppress_callbacks,
123 bool reset_state) override {} 122 bool reset_state) override {}
124 123
125 private: 124 private:
126 DialogClosedCallback callback_; 125 DialogClosedCallback callback_;
127 bool handle_; 126 bool handle_;
128 DISALLOW_COPY_AND_ASSIGN(TestJavaScriptDialogManager); 127 DISALLOW_COPY_AND_ASSIGN(TestJavaScriptDialogManager);
129 }; 128 };
130 129
131 } 130 }
132 131
(...skipping 1374 matching lines...) Expand 10 before | Expand all | Expand 10 after
1507 EXPECT_EQ("polyglottal", value); 1506 EXPECT_EQ("polyglottal", value);
1508 found++; 1507 found++;
1509 } else { 1508 } else {
1510 FAIL(); 1509 FAIL();
1511 } 1510 }
1512 } 1511 }
1513 EXPECT_EQ(2u, found); 1512 EXPECT_EQ(2u, found);
1514 } 1513 }
1515 1514
1516 } // namespace content 1515 } // namespace content
OLDNEW
« no previous file with comments | « components/app_modal/javascript_dialog_manager.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698