DevTools: move from Common module - Geometry and CSSShadowModel

DevTools: move from Common module - Geometry and CSSShadowModel

Geometry: Common -> UI
CSSShadowModel: Common -> InlineEditor

I namespaced three global variables in Geometry:
'Size', 'Insets', 'Constraints'

BUG=none

Review-Url: https://codereview.chromium.org/2626143004
Cr-Commit-Position: refs/heads/master@{#443491}
Committed: https://chromium.googlesource.com/chromium/src/+/8e36f0a45025a1005800562926443f2aeb9b0766

[chenwilliam, 2017-01-12 02:02:28]

chenwilliam@chromium.org changed reviewers:
+ pfeldman@chromium.org

[chenwilliam, 2017-01-12 02:02:29]

PTAL.

[pfeldman, 2017-01-12 02:27:14]

Your change name is not accurate - you move shadow model into inline editor
module.

https://codereview.chromium.org/2626143004/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/components/css-shadow-model.html
(right):

https://codereview.chromium.org/2626143004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/components/css-shadow-model.html:7:
self.runtime.loadModulePromise('inline_editor').then(run);
You should be able to add
var initialize_Test = function() {
  self.runtime.loadModulePromise('inline_editor');
}

instead of indenting the test. If that does not work, rename test to something
and keep its indentation for the sake of minimizing the diff.

[chenwilliam, 2017-01-12 18:46:00]

Description was changed from

==========
DevTools: move Geometry and CSSShadowModel (Common -> UI)

I namespaced three global variables in Geometry:
'Size', 'Insets', 'Constraints'

BUG=none
==========

to

==========
DevTools: move from Common module - Geometry and CSSShadowModel

Geometry: Common -> UI
CSSShadowModel: Common -> InlineEditor

I namespaced three global variables in Geometry:
'Size', 'Insets', 'Constraints'

BUG=none
==========

[chenwilliam, 2017-01-12 23:27:33]

PTAL.

https://codereview.chromium.org/2626143004/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/components/css-shadow-model.html
(right):

https://codereview.chromium.org/2626143004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/components/css-shadow-model.html:7:
self.runtime.loadModulePromise('inline_editor').then(run);
On 2017/01/12 02:27:14, pfeldman wrote:
> You should be able to add
> var initialize_Test = function() {
>   self.runtime.loadModulePromise('inline_editor');
> }
> 
> instead of indenting the test. If that does not work, rename test to something
> and keep its indentation for the sake of minimizing the diff.

Done.

[pfeldman, 2017-01-13 00:49:02]

lgtm

[chenwilliam, 2017-01-13 00:55:38]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2017-01-13 00:57:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:42:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484268938931950,
"parent_rev": "6f57ec35020860e39d1b6f520169bbeb9f3790a8", "commit_rev":
"8e36f0a45025a1005800562926443f2aeb9b0766"}

[commit-bot: I haz the power, 2017-01-13 04:43:18]

Description was changed from

==========
DevTools: move from Common module - Geometry and CSSShadowModel

Geometry: Common -> UI
CSSShadowModel: Common -> InlineEditor

I namespaced three global variables in Geometry:
'Size', 'Insets', 'Constraints'

BUG=none
==========

to

==========
DevTools: move from Common module - Geometry and CSSShadowModel

Geometry: Common -> UI
CSSShadowModel: Common -> InlineEditor

I namespaced three global variables in Geometry:
'Size', 'Insets', 'Constraints'

BUG=none

Review-Url: https://codereview.chromium.org/2626143004
Cr-Commit-Position: refs/heads/master@{#443491}
Committed:
https://chromium.googlesource.com/chromium/src/+/8e36f0a45025a100580056292644...
==========

[commit-bot: I haz the power, 2017-01-13 04:43:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8e36f0a45025a100580056292644...