Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js

Issue 2626143004: DevTools: move from Common module - Geometry and CSSShadowModel (Closed)
Patch Set: minimize test diff Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js
diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js b/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js
index 917896628b6e1dc1ce30f0b80191735166762dba..caf8827a7764b8052dde6f9a527f31c924b8b6e5 100644
--- a/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js
+++ b/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js
@@ -71,10 +71,10 @@ Emulation.EmulatedDevice = class {
/**
* @param {*} json
- * @return {!Insets}
+ * @return {!UI.Insets}
*/
function parseInsets(json) {
- return new Insets(
+ return new UI.Insets(
parseIntValue(json, 'left'), parseIntValue(json, 'top'), parseIntValue(json, 'right'),
parseIntValue(json, 'bottom'));
}
@@ -330,10 +330,10 @@ Emulation.EmulatedDevice = class {
}
};
-/** @typedef {!{title: string, orientation: string, insets: !Insets, image: ?string}} */
+/** @typedef {!{title: string, orientation: string, insets: !UI.Insets, image: ?string}} */
Emulation.EmulatedDevice.Mode;
-/** @typedef {!{width: number, height: number, outlineInsets: ?Insets, outlineImage: ?string}} */
+/** @typedef {!{width: number, height: number, outlineInsets: ?UI.Insets, outlineImage: ?string}} */
Emulation.EmulatedDevice.Orientation;
Emulation.EmulatedDevice.Horizontal = 'horizontal';
@@ -420,11 +420,15 @@ Emulation.EmulatedDevicesList = class extends Common.Object {
device.modes.push({
title: '',
orientation: Emulation.EmulatedDevice.Horizontal,
- insets: new Insets(0, 0, 0, 0),
+ insets: new UI.Insets(0, 0, 0, 0),
+ image: null
+ });
+ device.modes.push({
+ title: '',
+ orientation: Emulation.EmulatedDevice.Vertical,
+ insets: new UI.Insets(0, 0, 0, 0),
image: null
});
- device.modes.push(
- {title: '', orientation: Emulation.EmulatedDevice.Vertical, insets: new Insets(0, 0, 0, 0), image: null});
}
} else {
success = false;

Powered by Google App Engine
This is Rietveld 408576698