Changed EUnicodeBidi to an enum class and renamed its members

Changed EUnicodeBidi to an enum class and renamed its members

Changed EUnicodeBidi to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EUnicodeBidi to be used by generated
fields in ComputedStyleBase.

BUG=628043
Review-Url: https://codereview.chromium.org/2625553005
Cr-Commit-Position: refs/heads/master@{#442775}
Committed: https://chromium.googlesource.com/chromium/src/+/cc1cb9fbd275d9b119ffdaf31d7bec56cb5b4d8d

[sashab, 2017-01-10 04:16:37]

sashab@chromium.org changed reviewers:
+ napper@chromium.org

[sashab, 2017-01-10 04:21:34]

nasko, dcheng fyi

[napper, 2017-01-10 04:36:21]

lgtm

[sashab, 2017-01-10 05:25:15]

sashab@chromium.org changed reviewers:
+ aazzam@google.com

[sashab, 2017-01-10 05:25:15]

anna ptal :)

[aazzam, 2017-01-10 05:33:07]

lgtm

[sashab, 2017-01-10 23:13:59]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-01-10 23:14:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 23:26:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 23:26:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sashab, 2017-01-11 01:24:02]

sashab@chromium.org changed reviewers:
+ haraken@chromium.org

[sashab, 2017-01-11 01:24:03]

haraken@ ptal at platform/text/UnicodeBidi.h :)

[haraken, 2017-01-11 01:27:04]

LGTM

[sashab, 2017-01-11 01:30:12]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:30:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 03:00:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484098212187400, "parent_rev":
"9bce6bd169acf97126cfa4e8635c7564a8ab84e4", "commit_rev":
"cc1cb9fbd275d9b119ffdaf31d7bec56cb5b4d8d"}

[commit-bot: I haz the power, 2017-01-11 03:01:00]

Description was changed from

==========
Changed EUnicodeBidi to an enum class and renamed its members

Changed EUnicodeBidi to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EUnicodeBidi to be used by generated
fields in ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EUnicodeBidi to an enum class and renamed its members

Changed EUnicodeBidi to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EUnicodeBidi to be used by generated
fields in ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2625553005
Cr-Commit-Position: refs/heads/master@{#442775}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc1cb9fbd275d9b119ffdaf31d7b...
==========

[commit-bot: I haz the power, 2017-01-11 03:01:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc1cb9fbd275d9b119ffdaf31d7b...