Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc

Issue 2625553005: Changed EUnicodeBidi to an enum class and renamed its members (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc
index e058369583d2bda08f8f55be0fd9065ca79dd0c0..bc509ae2c4e0ce963b5ab5f0c2f65f6b5fe56972 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc
@@ -186,7 +186,7 @@ TEST_F(NGLayoutInlineItemsBuilderTest, BidiBlockOverride) {
Vector<NGLayoutInlineItem> items;
NGLayoutInlineItemsBuilder builder(&items);
RefPtr<ComputedStyle> block_style(ComputedStyle::create());
- block_style->setUnicodeBidi(Override);
+ block_style->setUnicodeBidi(EUnicodeBidi::kBidiOverride);
block_style->setDirection(TextDirection::kRtl);
builder.EnterBlock(block_style.get());
builder.Append("Hello", style_.get());
@@ -215,7 +215,7 @@ TEST_F(NGLayoutInlineItemsBuilderTest, BidiIsolate) {
builder.Append("Hello ", style_.get());
std::unique_ptr<LayoutInline> isolateRTL(
createLayoutInline([](ComputedStyle* style) {
- style->setUnicodeBidi(Isolate);
+ style->setUnicodeBidi(EUnicodeBidi::kIsolate);
style->setDirection(TextDirection::kRtl);
}));
builder.EnterInline(isolateRTL.get());
@@ -239,7 +239,7 @@ TEST_F(NGLayoutInlineItemsBuilderTest, BidiIsolateOverride) {
builder.Append("Hello ", style_.get());
std::unique_ptr<LayoutInline> isolateOverrideRTL(
createLayoutInline([](ComputedStyle* style) {
- style->setUnicodeBidi(IsolateOverride);
+ style->setUnicodeBidi(EUnicodeBidi::kIsolateOverride);
style->setDirection(TextDirection::kRtl);
}));
builder.EnterInline(isolateOverrideRTL.get());

Powered by Google App Engine
This is Rietveld 408576698