Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: third_party/WebKit/Source/platform/text/UnicodeBidi.h

Issue 2625553005: Changed EUnicodeBidi to an enum class and renamed its members (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/text/UnicodeBidi.h
diff --git a/third_party/WebKit/Source/platform/text/UnicodeBidi.h b/third_party/WebKit/Source/platform/text/UnicodeBidi.h
index da83361057d72272cf3925dbcaa12fd403ee9672..91923d2309cefa951d77d647d65c18260284e747 100644
--- a/third_party/WebKit/Source/platform/text/UnicodeBidi.h
+++ b/third_party/WebKit/Source/platform/text/UnicodeBidi.h
@@ -28,22 +28,24 @@
namespace blink {
-enum EUnicodeBidi {
- UBNormal,
- Embed,
- Override,
- Isolate,
- Plaintext,
- IsolateOverride,
+enum class EUnicodeBidi : unsigned {
+ kNormal,
+ kEmbed,
+ kBidiOverride,
+ kIsolate,
+ kPlaintext,
+ kIsolateOverride,
};
inline bool isIsolated(const EUnicodeBidi& unicodeBidi) {
- return unicodeBidi == Isolate || unicodeBidi == IsolateOverride ||
- unicodeBidi == Plaintext;
+ return unicodeBidi == EUnicodeBidi::kIsolate ||
+ unicodeBidi == EUnicodeBidi::kIsolateOverride ||
+ unicodeBidi == EUnicodeBidi::kPlaintext;
}
inline bool isOverride(EUnicodeBidi unicodeBidi) {
- return unicodeBidi == Override || unicodeBidi == IsolateOverride;
+ return unicodeBidi == EUnicodeBidi::kBidiOverride ||
+ unicodeBidi == EUnicodeBidi::kIsolateOverride;
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698