third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc - Issue 2625553005: Changed EUnicodeBidi to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc

Issue 2625553005: Changed EUnicodeBidi to an enum class and renamed its members (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc b/third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc

index 4f81ef3a245e65b5d4c048487ccc9b8613340f0d..ce87586d59f5f7000ffe7f7aed17401b0b03f943 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc

@@ -21,7 +21,7 @@ bool NGBidiParagraph::SetParagraph(const String& text,

ICUError error;

ubidi_setPara(

ubidi_, text.characters16(), text.length(),

- block_style->unicodeBidi() == Plaintext

+ block_style->unicodeBidi() == EUnicodeBidi::kPlaintext

? UBIDI_DEFAULT_LTR

: (block_style->direction() == TextDirection::kRtl ? UBIDI_RTL

: UBIDI_LTR),