Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2624703002: Removed ComputedStyle::inheritUnicodeBidiFrom (Closed)

Created:
3 years, 11 months ago by sashab
Modified:
3 years, 11 months ago
Reviewers:
napper
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed ComputedStyle::inheritUnicodeBidiFrom Removed ComputedStyle::inheritUnicodeBidiFrom, which only had one callsite in ComputedStyle.cpp, and replaced the callsite with the method's implementation. BUG=628043 Review-Url: https://codereview.chromium.org/2624703002 Cr-Commit-Position: refs/heads/master@{#442514} Committed: https://chromium.googlesource.com/chromium/src/+/eb5e40651ca7d137d9b4840a61ce050b5ac04f12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
sashab
3 years, 11 months ago (2017-01-10 03:49:06 UTC) #2
napper
lgtm
3 years, 11 months ago (2017-01-10 03:55:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624703002/1
3 years, 11 months ago (2017-01-10 03:56:54 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 06:15:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb5e40651ca7d137d9b4840a61ce...

Powered by Google App Engine
This is Rietveld 408576698