Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: third_party/WebKit/Source/core/layout/BidiRunForLine.cpp

Issue 2625553005: Changed EUnicodeBidi to an enum class and renamed its members (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
diff --git a/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp b/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
index eedb9151ca9c0fccab8d5f939f2ca879511d26b2..a7df84b50c103355a98a2771a17dd87839b1890f 100644
--- a/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
+++ b/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
@@ -142,11 +142,12 @@ void constructBidiRunsForLine(InlineBidiResolver& topResolver,
topResolver.midpointStateForIsolatedRun(isolatedRun.runToReplace);
EUnicodeBidi unicodeBidi = isolatedInline.style()->unicodeBidi();
TextDirection direction;
- if (unicodeBidi == Plaintext) {
+ if (unicodeBidi == EUnicodeBidi::kPlaintext) {
direction = determinePlaintextDirectionality(
isolatedInline, isNewUBAParagraph ? startObj : 0);
} else {
- ASSERT(unicodeBidi == Isolate || unicodeBidi == IsolateOverride);
+ DCHECK(unicodeBidi == EUnicodeBidi::kIsolate ||
+ unicodeBidi == EUnicodeBidi::kIsolateOverride);
direction = isolatedInline.style()->direction();
}
isolatedResolver.setStatus(BidiStatus::createForIsolate(
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698