Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2620873002: Renamed EUnicodeBidi to just UnicodeBidi (Closed)

Created:
3 years, 11 months ago by sashab
Modified:
3 years, 11 months ago
Reviewers:
haraken, napper, gozzard, dcheng
CC:
ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, atotic+reviews_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, Rik, cbiesinger, chromium-reviews, dglazkov+blink, dshwang, krit, eae+blinkwatch, f(malita), fs, glebl+reviews_chromium.org, gyuyoung2, jchaffraix+rendering, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, leviw+bidiwatch_chromium.org, ojan+watch_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed EUnicodeBidi to just UnicodeBidi Renamed EUnicodeBidi to just UnicodeBidi to match the name of the file, UnicodeBidi.h. This is pre-work to allow UnicodeBidi to be used by generated fields in ComputedStyleBase, and also better matches the style guidelines (class names should have the same name as the file). BUG=628043 Review-Url: https://codereview.chromium.org/2620873002 Cr-Commit-Position: refs/heads/master@{#443041} Committed: https://chromium.googlesource.com/chromium/src/+/bcbe36cce42ae13bee7b03a6e037237676959935

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -74 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/BidiRunForLine.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMenuList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TextRunConstructor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineIterator.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/UnicodeBidi.h View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (13 generated)
sashab
3 years, 11 months ago (2017-01-10 04:21:12 UTC) #2
napper
lgtm
3 years, 11 months ago (2017-01-10 04:31:52 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2625553005 Patch 1). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-10 04:33:28 UTC) #6
sashab
gozzard ptal :)
3 years, 11 months ago (2017-01-10 23:14:48 UTC) #8
gozzard
lgtm
3 years, 11 months ago (2017-01-11 03:07:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620873002/1
3 years, 11 months ago (2017-01-11 03:11:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/133592) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-11 03:14:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620873002/20001
3 years, 11 months ago (2017-01-11 03:35:42 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/339149)
3 years, 11 months ago (2017-01-11 04:07:21 UTC) #18
sashab
haraken@ please rs platform/ and modules/ dcheng@ please rs web/ ty :)
3 years, 11 months ago (2017-01-11 04:09:08 UTC) #20
dcheng
web lgtm
3 years, 11 months ago (2017-01-11 08:39:04 UTC) #21
haraken
LGTM
3 years, 11 months ago (2017-01-11 08:50:22 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620873002/20001
3 years, 11 months ago (2017-01-11 22:31:04 UTC) #24
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 23:08:40 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bcbe36cce42ae13bee7b03a6e037...

Powered by Google App Engine
This is Rietveld 408576698