[SubZero] Fix code generation issues occurred in Cross-test and PNaCL smoke-tests

[SubZero] Fix code generation issues occurred in Cross-test and PNaCL smoke-tests

The patch fixes various code generation issues found during testing of Cross-test and PNaCL smoke-test framework.

     1)	To keep track of branches to same label, relative position of the branch from previous branch is used.
     2)	Fixed encoding of conditional mov instructions
     3)	Added MovFP64ToI64 instruction for f64 to i64 move
     4)	Handled vector-types in Phi nodes
     5)	Fixed alignment of spilled vector arguments on stack
     6)	Save-restore FP registers
     7)	Fixed code generation for Zext and Sext operations
     8)	Fixed InsertElement for vi16x8 type

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2bbda7f48c30683eea26e4901054c58b79221d53

[jaydeep.patil, 2017-01-10 05:54:49]

Description was changed from

==========
[SubZero] Fix code generation issues occurred in Cross-test and PNaCL
smoke-tests

The patch fixes various code generation issues found during testing of
Cross-test and PNaCL smoke-test framework.

     1)	To keep track of branches to same label, relative position of the branch
from previous branch is used.
     2)	Fixed encoding of conditional mov instructions
     3)	Added MovFP64ToI64 instruction for f64 to i64 move
     4)	Handled vector-types in Phi nodes
     5)	Fixed alignment of spilled vector arguments on stack
     6)	Save-restore FP registers
     7)	Fixed code generation for Zext and Sext operations
     8)	Fixed InsertElement for vi16x8 type
==========

to

==========
[SubZero] Fix code generation issues occurred in Cross-test and PNaCL
smoke-tests

The patch fixes various code generation issues found during testing of
Cross-test and PNaCL smoke-test framework.

     1)	To keep track of branches to same label, relative position of the branch
from previous branch is used.
     2)	Fixed encoding of conditional mov instructions
     3)	Added MovFP64ToI64 instruction for f64 to i64 move
     4)	Handled vector-types in Phi nodes
     5)	Fixed alignment of spilled vector arguments on stack
     6)	Save-restore FP registers
     7)	Fixed code generation for Zext and Sext operations
     8)	Fixed InsertElement for vi16x8 type
==========

[jaydeep.patil, 2017-01-10 05:54:49]

jaydeep.patil@imgtec.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com,
makdstefan@gmail.com, sagar.thakur@imgtec.com, stichnot@chromium.org

[Jim Stichnoth, 2017-01-11 05:23:58]

https://codereview.chromium.org/2619943003/diff/1/src/IceAssemblerMIPS32.cpp
File src/IceAssemblerMIPS32.cpp (right):

https://codereview.chromium.org/2619943003/diff/1/src/IceAssemblerMIPS32.cpp#...
src/IceAssemblerMIPS32.cpp:200: if (NextBrPc)
In the code base, we have preferred "if (x != 0)" instead of "if (x)" for
non-bool condition types like here (and several places below).

https://codereview.chromium.org/2619943003/diff/1/src/IceInstMIPS32.h
File src/IceInstMIPS32.h (right):

https://codereview.chromium.org/2619943003/diff/1/src/IceInstMIPS32.h#newcode...
src/IceInstMIPS32.h:1353: Int64Part getInt64Part() { return Int64HiLo; }
const

https://codereview.chromium.org/2619943003/diff/1/src/IcePhiLoweringImpl.h
File src/IcePhiLoweringImpl.h (right):

https://codereview.chromium.org/2619943003/diff/1/src/IcePhiLoweringImpl.h#ne...
src/IcePhiLoweringImpl.h:39: Type DstTy = Dest->getType();
The code base usually names this "DestTy".

https://codereview.chromium.org/2619943003/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2619943003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:1722: if (Dest && SrcTy == IceType_f64) {
Dest != nullptr

[jaydeep.patil, 2017-01-11 05:45:10]

https://codereview.chromium.org/2619943003/diff/1/src/IceAssemblerMIPS32.cpp
File src/IceAssemblerMIPS32.cpp (right):

https://codereview.chromium.org/2619943003/diff/1/src/IceAssemblerMIPS32.cpp#...
src/IceAssemblerMIPS32.cpp:200: if (NextBrPc)
On 2017/01/11 05:23:58, Jim Stichnoth wrote:
> In the code base, we have preferred "if (x != 0)" instead of "if (x)" for
> non-bool condition types like here (and several places below).

Done.

https://codereview.chromium.org/2619943003/diff/1/src/IceInstMIPS32.h
File src/IceInstMIPS32.h (right):

https://codereview.chromium.org/2619943003/diff/1/src/IceInstMIPS32.h#newcode...
src/IceInstMIPS32.h:1353: Int64Part getInt64Part() { return Int64HiLo; }
On 2017/01/11 05:23:58, Jim Stichnoth wrote:
> const

Done.

https://codereview.chromium.org/2619943003/diff/1/src/IcePhiLoweringImpl.h
File src/IcePhiLoweringImpl.h (right):

https://codereview.chromium.org/2619943003/diff/1/src/IcePhiLoweringImpl.h#ne...
src/IcePhiLoweringImpl.h:39: Type DstTy = Dest->getType();
On 2017/01/11 05:23:58, Jim Stichnoth wrote:
> The code base usually names this "DestTy".

Done.

https://codereview.chromium.org/2619943003/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2619943003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:1722: if (Dest && SrcTy == IceType_f64) {
On 2017/01/11 05:23:58, Jim Stichnoth wrote:
> Dest != nullptr

Done.

[Jim Stichnoth, 2017-01-11 05:48:45]

lgtm

[Jim Stichnoth, 2017-01-11 05:49:01]

Description was changed from

==========
[SubZero] Fix code generation issues occurred in Cross-test and PNaCL
smoke-tests

The patch fixes various code generation issues found during testing of
Cross-test and PNaCL smoke-test framework.

     1)	To keep track of branches to same label, relative position of the branch
from previous branch is used.
     2)	Fixed encoding of conditional mov instructions
     3)	Added MovFP64ToI64 instruction for f64 to i64 move
     4)	Handled vector-types in Phi nodes
     5)	Fixed alignment of spilled vector arguments on stack
     6)	Save-restore FP registers
     7)	Fixed code generation for Zext and Sext operations
     8)	Fixed InsertElement for vi16x8 type
==========

to

==========
[SubZero] Fix code generation issues occurred in Cross-test and PNaCL
smoke-tests

The patch fixes various code generation issues found during testing of
Cross-test and PNaCL smoke-test framework.

     1)	To keep track of branches to same label, relative position of the branch
from previous branch is used.
     2)	Fixed encoding of conditional mov instructions
     3)	Added MovFP64ToI64 instruction for f64 to i64 move
     4)	Handled vector-types in Phi nodes
     5)	Fixed alignment of spilled vector arguments on stack
     6)	Save-restore FP registers
     7)	Fixed code generation for Zext and Sext operations
     8)	Fixed InsertElement for vi16x8 type

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2017-01-11 05:49:02]

Committed patchset #2 (id:20001) manually as
2bbda7f48c30683eea26e4901054c58b79221d53 (presubmit successful).