Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2606103002: Rename convert_404_to_None -> return_none_on_404. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename convert_404_to_None -> return_none_on_404. Reason: Pylint gives a warning about the current name because variable and method names generally don't have capitals in them. Also, I think the new name is slightly clearer. BUG=643937 Committed: https://crrev.com/e50b0019b1a4fa5d47499b5733d9402b14ff8e6f Cr-Commit-Position: refs/heads/master@{#441043}

Patch Set 1 #

Messages

Total messages: 13 (9 generated)
jeffcarp
lgtm
3 years, 11 months ago (2016-12-30 06:02:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606103002/1
3 years, 11 months ago (2016-12-31 18:29:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-31 20:34:23 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:54:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e50b0019b1a4fa5d47499b5733d9402b14ff8e6f
Cr-Commit-Position: refs/heads/master@{#441043}

Powered by Google App Engine
This is Rietveld 408576698