Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 2606103002: Rename convert_404_to_None -> return_none_on_404. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index a74fa6502e6f905d79ca2e51bf982b9a9fb2da63..3cedbcace83418d608c8a4b893e200b3c4c7cc1f 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -249,7 +249,7 @@ class RebaselineTest(AbstractRebaseliningCommand):
target_baseline = self._tool.filesystem.join(baseline_directory, self._file_name_for_expected_result(test_name, suffix))
_log.debug("Retrieving source %s for target %s.", source_baseline, target_baseline)
- self._save_baseline(self._tool.web.get_binary(source_baseline, convert_404_to_None=True),
+ self._save_baseline(self._tool.web.get_binary(source_baseline, return_none_on_404=True),
target_baseline)
def _rebaseline_test_and_update_expectations(self, options):
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698