Rename convert_404_to_None -> return_none_on_404.

third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py

 # Copyright (C) 2010 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 23 matching lines @@
 
 
 class NetworkTimeout(Exception):
 
     def __str__(self):
         return 'NetworkTimeout'
 
 
 class NetworkTransaction(object):
 
-    # TODO(qyearsley): Rename convert_404_to_None
+    # TODO(qyearsley): Rename return_none_on_404
     # pylint: disable=invalid-name
 
-    def __init__(self, initial_backoff_seconds=10, grown_factor=1.5, timeout_seconds=(10 * 60), convert_404_to_None=False):
+    def __init__(self, initial_backoff_seconds=10, grown_factor=1.5, timeout_seconds=(10 * 60), return_none_on_404=False):
         self._initial_backoff_seconds = initial_backoff_seconds
         self._grown_factor = grown_factor
         self._timeout_seconds = timeout_seconds
-        self._convert_404_to_None = convert_404_to_None
+        self._return_none_on_404 = return_none_on_404
         self._total_sleep = 0
         self._backoff_seconds = 0
 
     def run(self, request):
         self._total_sleep = 0
         self._backoff_seconds = self._initial_backoff_seconds
         while True:
             try:
                 return request()
             except urllib2.HTTPError as error:
-                if self._convert_404_to_None and error.code == 404:
+                if self._return_none_on_404 and error.code == 404:
                     return None
                 self._check_for_timeout()
                 _log.warning("Received HTTP status %s loading \"%s\".  Retrying in %s seconds...",
                              error.code, error.filename, self._backoff_seconds)
                 self._sleep()
 
     def _check_for_timeout(self):
         if self._total_sleep + self._backoff_seconds > self._timeout_seconds:
             raise NetworkTimeout()
 
     def _sleep(self):
         time.sleep(self._backoff_seconds)
         self._total_sleep += self._backoff_seconds
         self._backoff_seconds *= self._grown_factor