Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py

Issue 2606103002: Rename convert_404_to_None -> return_none_on_404. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py
index ac323a84508d1262bda21ca448ee6e8a79b0bb5a..6e75ab2fde60a884aa0c17cf5feece9dbd923dee 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py
@@ -35,11 +35,11 @@ class MockWeb(object):
self.urls = urls or {}
self.urls_fetched = []
- def get_binary(self, url, convert_404_to_None=False):
+ def get_binary(self, url, return_none_on_404=False):
self.urls_fetched.append(url)
if url in self.urls:
return self.urls[url]
- return "MOCK Web result, convert 404 to None=%s" % convert_404_to_None
+ return "MOCK Web result, convert 404 to None=%s" % return_none_on_404
# FIXME: Classes which are using Browser probably want to use Web instead.

Powered by Google App Engine
This is Rietveld 408576698