third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction_unittest.py - Issue 2606103002: Rename convert_404_to_None -> return_none_on_404.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction_unittest.py

Issue 2606103002: Rename convert_404_to_None -> return_none_on_404. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction_unittest.py

index 62fb6082673bcb97bbf7b725df961f1ec25204ae..c63ab0548d42efdb92dec8eb1a9cc2c37354b104 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction_unittest.py

@@ -78,7 +78,7 @@ class NetworkTransactionTest(LoggingTestCase):

'Retrying in 0.0 seconds...\n'])

def test_convert_404_to_none(self):

- transaction = NetworkTransaction(convert_404_to_None=True)

+ transaction = NetworkTransaction(return_none_on_404=True)

self.assertIsNone(transaction.run(self._raise_404_error))

def test_timeout(self):