third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py - Issue 2606103002: Rename convert_404_to_None -> return_none_on_404.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py

Issue 2606103002: Rename convert_404_to_None -> return_none_on_404. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py

index 167548e13143baaa71de4846bd32f3a09b4c40e1..f640de75585fe0aa836b5d74c5f109b049f2d2da 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py

@@ -33,5 +33,5 @@ from webkitpy.common.net.network_transaction import NetworkTransaction

class Web(object):

- def get_binary(self, url, convert_404_to_None=False):

- return NetworkTransaction(convert_404_to_None=convert_404_to_None).run(lambda: urllib2.urlopen(url).read())

+ def get_binary(self, url, return_none_on_404=False):

+ return NetworkTransaction(return_none_on_404=return_none_on_404).run(lambda: urllib2.urlopen(url).read())