Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

Issue 2606103002: Rename convert_404_to_None -> return_none_on_404. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
index 7a2e9911e549aec280f86fd3a4b0e5039698c876..88e2988bfcde99a325c642351347ab41003013e2 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
@@ -86,7 +86,7 @@ class BuildBot(object):
both with and without ("ignored").
"""
url_base = "%s/%s" % (self.builder_results_url_base(build.builder_name), build.build_number)
- return NetworkTransaction(convert_404_to_None=True).run(
+ return NetworkTransaction(return_none_on_404=True).run(
lambda: self._fetch_file(url_base, "retry_summary.json"))
def accumulated_results_url_base(self, builder_name):
@@ -103,9 +103,9 @@ class BuildBot(object):
@memoized
def fetch_layout_test_results(self, results_url):
"""Returns a LayoutTestResults object for results fetched from a given URL."""
- results_file = NetworkTransaction(convert_404_to_None=True).run(
+ results_file = NetworkTransaction(return_none_on_404=True).run(
lambda: self._fetch_file(results_url, "failing_results.json"))
- revision = NetworkTransaction(convert_404_to_None=True).run(
+ revision = NetworkTransaction(return_none_on_404=True).run(
lambda: self._fetch_file(results_url, "LAST_CHANGE"))
if not revision:
results_file = None
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698