Fix positioning of "text-underline-position:under" for multi-elements

Fix positioning of "text-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2602793004
Cr-Commit-Position: refs/heads/master@{#445597}
Committed: https://chromium.googlesource.com/chromium/src/+/2ac0bb3d271e109b6f71929eecc1e44442f9576b

[kojii, 2016-12-28 06:13:40]

Description was changed from

==========
WIP: underline-position-under

BUG=
==========

to

==========
WIP: underline-position-under

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2016-12-28 06:48:13]

Description was changed from

==========
WIP: underline-position-under

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
WIP: underline-position-under

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-01-20 07:27:26]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 07:27:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-01-20 07:37:00]

Description was changed from

==========
WIP: underline-position-under

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet
==========

[kojii, 2017-01-20 07:39:28]

kojii@chromium.org changed reviewers:
+ drott@chromium.org

[kojii, 2017-01-20 07:39:29]

drott@, PTAL.

I wanted to fix perf, automatic for CJK, and Meiryo, all of which are not in
this CL, but after some investigation, this change needs to land before working
on them.

[kojii, 2017-01-20 07:40:03]

Description was changed from

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet
==========

to

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
==========

[kojii, 2017-01-20 07:40:38]

Description was changed from

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
==========

to

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528 (1-3).

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
==========

[kojii, 2017-01-20 07:41:53]

Description was changed from

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528 (1-3).

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
==========

to

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528 (1-3).

Some rebaselines are needed for 5 and 6.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
==========

[kojii, 2017-01-20 07:42:20]

Description was changed from

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528 (1-3).

Some rebaselines are needed for 5 and 6.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
==========

to

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap for "under" doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528 (1-3).

Some rebaselines are needed for 5 and 6.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
==========

[commit-bot: I haz the power, 2017-01-20 10:05:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 10:05:28]

Dry run: This issue passed the CQ dry run.

[drott, 2017-01-20 16:01:08]

Thanks for porting this, Koji. I'll need a bit more time reviewing this. Can the
code for fixes 1.-6. be split into smaller portions or is it interdependent?
Smaller CLs would make this easier.

[kojii, 2017-01-20 16:37:01]

On 2017/01/20 at 16:01:08, drott wrote:
> Thanks for porting this, Koji. I'll need a bit more time reviewing this. Can
the code for fixes 1.-6. be split into smaller portions or is it interdependent?
Smaller CLs would make this easier.

Thanks for having a look, 1-4 are hard to split but 5 and 6 are possible, I'll
try.

[kojii, 2017-01-20 17:12:00]

Description was changed from

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap for "under" doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528 (1-3).

Some rebaselines are needed for 5 and 6.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
==========

to

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap for "under" doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528 (1-3).

Some rebaselines are needed for 5 and 6.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-01-20 17:12:04]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 17:12:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 17:28:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 17:28:22]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[kojii, 2017-01-20 17:33:38]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 17:33:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 18:40:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 18:40:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-01-20 18:49:38]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 18:49:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 20:37:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 20:37:41]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-01-20 21:54:10]

PTAL, 5 and 6 are split. Still not small, sorry, but now this is almost the same
as wkb.ug/141528.

[kojii, 2017-01-20 21:57:40]

Description was changed from

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes
5. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
6. Gap for "under" doesn't match to the spec nor to the use cases

This patch incorporates WebKit fixes in wkb.ug/141528 (1-3).

Some rebaselines are needed for 5 and 6.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857
4. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
5. Gap for "under" doesn't match to the spec nor to the use cases

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-01-21 04:50:26]

Description was changed from

==========
Fix multiple issues with text-underline-position:under

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857
4. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
5. Gap for "under" doesn't match to the spec nor to the use cases

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix positioning oftext-underline-position:under for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857
4. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
5. Gap for "under" doesn't match to the spec nor to the use cases

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-01-21 05:09:38]

Description was changed from

==========
Fix positioning oftext-underline-position:under for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857
4. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
5. Gap for "under" doesn't match to the spec nor to the use cases

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix positioning "oftext-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857
4. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
5. Gap for "under" doesn't match to the spec nor to the use cases

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-01-21 11:01:00]

Description was changed from

==========
Fix positioning "oftext-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857
4. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
5. Gap for "under" doesn't match to the spec nor to the use cases

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix positioning of "text-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857
4. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
5. Gap for "under" doesn't match to the spec nor to the use cases

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-01-21 18:29:54]

Description was changed from

==========
Fix positioning of "text-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

This patch does not include following fixes, they will be in future
patches.
1. Performance implications (O(n^2) for under)
2. Automatic positions for CJK text due to the performance concern
3. Incorrect under position for fonts with a large internal leading
   such as Meiryo crbug.com/681857
4. Doesn't support language-appropriate position[1], different behavior
   from Edge/Gecko
5. Gap for "under" doesn't match to the spec nor to the use cases

[1] https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix positioning of "text-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-01-21 18:31:25]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 18:31:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 20:55:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 20:55:13]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-01-23 03:14:37]

Description was changed from

==========
Fix positioning of "text-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix positioning of "text-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

BUG=3715,677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[kojii, 2017-01-23 03:14:46]

Description was changed from

==========
Fix positioning of "text-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

BUG=3715,677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix positioning of "text-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[drott, 2017-01-23 08:14:44]

Thanks for splitting, that makes it easier. Mostly makes sense to me, even
though I am not too familiar with the higher level things of finding underline
group/ancestors and computing the max/min across the line, but LGTM with the nit
of parameter redundancy.

[kojii, 2017-01-23 09:01:21]

On 2017/01/23 at 08:14:44, drott wrote:
> ...with the nit of parameter redundancy.

Did you mean to remove |maxLogicalBottom| and |minLogicalTop| from the header,
or use pointers rather than in&return for them?

[drott, 2017-01-23 10:30:37]

Oh, wow... I keep clicking reply instead of "M" for publishing comments...sorry.
This is what I meant.

https://codereview.chromium.org/2602793004/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp (right):

https://codereview.chromium.org/2602793004/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp:1144: styleToUse,
fontData->getFontMetrics(),
If you're passing ComputedStyle styleToUse as a whole, please remove the
redundant first parameter styleToUse.getTextUnderlinePosition().

[kojii, 2017-01-23 11:37:59]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 11:38:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-01-23 13:17:43]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-01-23 13:17:44]

eae@ PTAL.

Thank you drott@, yeah, "publish" and "reply" are confusing.

https://codereview.chromium.org/2602793004/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp (right):

https://codereview.chromium.org/2602793004/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp:1144: styleToUse,
fontData->getFontMetrics(),
On 2017/01/23 at 10:30:37, drott wrote:
> If you're passing ComputedStyle styleToUse as a whole, please remove the
redundant first parameter styleToUse.getTextUnderlinePosition().

Done.

[drott, 2017-01-23 14:12:01]

LGTM

[commit-bot: I haz the power, 2017-01-23 14:20:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 14:20:37]

Dry run: This issue passed the CQ dry run.

[eae, 2017-01-23 18:20:35]

LGTM

[kojii, 2017-01-24 01:56:58]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-01-24 01:57:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 02:08:07]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1485223018188240,
"parent_rev": "c155a9d6b32923b271a36dba878f10c41b3ae3d1", "commit_rev":
"2ac0bb3d271e109b6f71929eecc1e44442f9576b"}

[commit-bot: I haz the power, 2017-01-24 02:09:14]

Description was changed from

==========
Fix positioning of "text-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix positioning of "text-underline-position:under" for multi-elements

This patch fixes following issues in text-underline-position: under
1. Doesn't work with vertical-lr
2. Is always including replaced elements in the "under" check
3. Doesn't limit the "under" check to the containing element with the
   text-decoration specified
4. Computes incorrect position for mixed sizes

This patch is a port of wkb.ug/141528.

BUG=677240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2602793004
Cr-Commit-Position: refs/heads/master@{#445597}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ac0bb3d271e109b6f71929eecc1...
==========

[commit-bot: I haz the power, 2017-01-24 02:09:16]

Committed patchset #14 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/2ac0bb3d271e109b6f71929eecc1...