third_party/WebKit/Source/core/layout/line/InlineBox.h - Issue 2602793004: Fix positioning of "text-underline-position:under" for multi-elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineBox.h

Issue 2602793004: Fix positioning of "text-underline-position:under" for multi-elements (Closed)

Patch Set: drott nit Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/InlineBox.h b/third_party/WebKit/Source/core/layout/line/InlineBox.h

index 16a2ed28a535e6c82b5770ac4907d79c175957b3..f4365e638b135e835bb721c4cf56a72985b9533e 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineBox.h

+++ b/third_party/WebKit/Source/core/layout/line/InlineBox.h

@@ -173,6 +173,9 @@ class CORE_EXPORT InlineBox : public DisplayItemClient {

m_bitfields.setFirstLine(firstLine);

}

bool isFirstLineStyle() const { return m_bitfields.firstLine(); }

+ const ComputedStyle& lineStyleRef() const {

+ return getLineLayoutItem().styleRef(isFirstLineStyle());

+ }

void remove(MarkLineBoxes = MarkLineBoxesDirty);