Fix positioning of "text-underline-position:under" for multi-elements

third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
  *               All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 870 matching lines @@
       lineBottomIncludingMargins =
           std::max(lineBottom, lineBottomIncludingMargins);
     }
 
     if (getLineLayoutItem().style()->isFlippedLinesWritingMode())
       flipLinesInBlockDirection(lineTopIncludingMargins,
                                 lineBottomIncludingMargins);
   }
 }
 
-void InlineFlowBox::computeMaxLogicalTop(LayoutUnit& maxLogicalTop) const {
+LayoutUnit InlineFlowBox::maxLogicalBottomForUnderline(
+    LineLayoutItem decorationObject,
+    LayoutUnit maxLogicalBottom) const {
   for (InlineBox* curr = firstChild(); curr; curr = curr->nextOnLine()) {
     if (curr->getLineLayoutItem().isOutOfFlowPositioned())
       continue;  // Positioned placeholders don't affect calculations.
 
-    if (descendantsHaveSameLineHeightAndBaseline())
+    // If the text decoration isn't in effect on the child, it must be outside
+    // of |decorationObject|.
+    if (!(curr->lineStyleRef().textDecorationsInEffect() &
+          TextDecorationUnderline))
       continue;
 
-    maxLogicalTop = std::max<LayoutUnit>(maxLogicalTop, curr->y());
-    LayoutUnit localMaxLogicalTop;
-    if (curr->isInlineFlowBox())
-      toInlineFlowBox(curr)->computeMaxLogicalTop(localMaxLogicalTop);
-    maxLogicalTop = std::max<LayoutUnit>(maxLogicalTop, localMaxLogicalTop);
+    if (decorationObject && decorationObject.isLayoutInline() &&
+        !isAncestorAndWithinBlock(decorationObject, curr->getLineLayoutItem()))
+      continue;
+
+    if (curr->isInlineFlowBox()) {
+      maxLogicalBottom = toInlineFlowBox(curr)->maxLogicalBottomForUnderline(
+          decorationObject, maxLogicalBottom);
+    } else if (curr->isInlineTextBox()) {
+      maxLogicalBottom = std::max(maxLogicalBottom, curr->logicalBottom());
+    }
   }
+  return maxLogicalBottom;
+}
+
+LayoutUnit InlineFlowBox::minLogicalTopForUnderline(
+    LineLayoutItem decorationObject,
+    LayoutUnit minLogicalTop) const {
+  for (InlineBox* curr = firstChild(); curr; curr = curr->nextOnLine()) {
+    if (curr->getLineLayoutItem().isOutOfFlowPositioned())
+      continue;  // Positioned placeholders don't affect calculations.
+
+    // If the text decoration isn't in effect on the child, it must be outside
+    // of |decorationObject|.
+    if (!(curr->lineStyleRef().textDecorationsInEffect() &
+          TextDecorationUnderline))
+      continue;
+
+    if (decorationObject && decorationObject.isLayoutInline() &&
+        !isAncestorAndWithinBlock(decorationObject, curr->getLineLayoutItem()))
+      continue;
+
+    if (curr->isInlineFlowBox()) {
+      minLogicalTop = toInlineFlowBox(curr)->minLogicalTopForUnderline(
+          decorationObject, minLogicalTop);
+    } else if (curr->isInlineTextBox()) {
+      minLogicalTop = std::min(minLogicalTop, curr->logicalTop());
+    }
+  }
+  return minLogicalTop;
 }
 
 void InlineFlowBox::flipLinesInBlockDirection(LayoutUnit lineTop,
                                               LayoutUnit lineBottom) {
   // Flip the box on the line such that the top is now relative to the
   // lineBottom instead of the lineTop.
   setLogicalTop(lineBottom - (logicalTop() - lineTop) - logicalHeight());
 
   for (InlineBox* curr = firstChild(); curr; curr = curr->nextOnLine()) {
     if (curr->getLineLayoutItem().isOutOfFlowPositioned())
@@ skipping 731 matching lines @@
     ASSERT(child->prevOnLine() == prev);
     prev = child;
   }
   ASSERT(prev == m_lastChild);
 #endif
 }
 
 #endif
 
 }  // namespace blink