Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: third_party/WebKit/Source/core/layout/line/RootInlineBox.h

Issue 2602793004: Fix positioning of "text-underline-position:under" for multi-elements (Closed)
Patch Set: drott nit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 LayoutUnit logicalBottomVisualOverflow() const { 195 LayoutUnit logicalBottomVisualOverflow() const {
196 return InlineFlowBox::logicalBottomVisualOverflow(lineBottom()); 196 return InlineFlowBox::logicalBottomVisualOverflow(lineBottom());
197 } 197 }
198 LayoutUnit logicalTopLayoutOverflow() const { 198 LayoutUnit logicalTopLayoutOverflow() const {
199 return InlineFlowBox::logicalTopLayoutOverflow(lineTop()); 199 return InlineFlowBox::logicalTopLayoutOverflow(lineTop());
200 } 200 }
201 LayoutUnit logicalBottomLayoutOverflow() const { 201 LayoutUnit logicalBottomLayoutOverflow() const {
202 return InlineFlowBox::logicalBottomLayoutOverflow(lineBottom()); 202 return InlineFlowBox::logicalBottomLayoutOverflow(lineBottom());
203 } 203 }
204 204
205 // Used to calculate the underline offset for TextUnderlinePositionUnder.
206 LayoutUnit maxLogicalTop() const;
207
208 Node* getLogicalStartBoxWithNode(InlineBox*&) const; 205 Node* getLogicalStartBoxWithNode(InlineBox*&) const;
209 Node* getLogicalEndBoxWithNode(InlineBox*&) const; 206 Node* getLogicalEndBoxWithNode(InlineBox*&) const;
210 207
211 const char* boxName() const override; 208 const char* boxName() const override;
212 209
213 private: 210 private:
214 LayoutUnit beforeAnnotationsAdjustment() const; 211 LayoutUnit beforeAnnotationsAdjustment() const;
215 212
216 // This folds into the padding at the end of InlineFlowBox on 64-bit. 213 // This folds into the padding at the end of InlineFlowBox on 64-bit.
217 unsigned m_lineBreakPos; 214 unsigned m_lineBreakPos;
(...skipping 12 matching lines...) Expand all
230 LayoutUnit m_lineBottom; 227 LayoutUnit m_lineBottom;
231 LayoutUnit m_lineTopWithLeading; 228 LayoutUnit m_lineTopWithLeading;
232 LayoutUnit m_lineBottomWithLeading; 229 LayoutUnit m_lineBottomWithLeading;
233 LayoutUnit m_selectionBottom; 230 LayoutUnit m_selectionBottom;
234 LayoutUnit m_paginationStrut; 231 LayoutUnit m_paginationStrut;
235 }; 232 };
236 233
237 } // namespace blink 234 } // namespace blink
238 235
239 #endif // RootInlineBox_h 236 #endif // RootInlineBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698