third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp - Issue 2602793004: Fix positioning of "text-underline-position:under" for multi-elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

Issue 2602793004: Fix positioning of "text-underline-position:under" for multi-elements (Closed)

Patch Set: drott nit Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp b/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

index c52beeb4b800a96c97c3cca76b7c111723f7d57c..0810e28bf99c21ed525964a7e95562f6e26e090e 100644

--- a/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

@@ -302,12 +302,6 @@ LayoutUnit RootInlineBox::alignBoxesInBlockDirection(

return heightOfBlock + maxHeight;

}

-LayoutUnit RootInlineBox::maxLogicalTop() const {

- LayoutUnit maxLogicalTop;

- computeMaxLogicalTop(maxLogicalTop);

- return maxLogicalTop;

LayoutUnit RootInlineBox::beforeAnnotationsAdjustment() const {

LayoutUnit result;