Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

Issue 2602793004: Fix positioning of "text-underline-position:under" for multi-elements (Closed)
Patch Set: drott nit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
index acf143bc97088ab3e65da4b38df9a7cae9aa5596..7cf8ddd3b51922418453d0e1917d708c1d1fbbbb 100644
--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
@@ -393,6 +393,11 @@ class InlineFlowBox : public InlineBox {
lineTop, lineBottom);
}
+ LayoutUnit maxLogicalBottomForUnderline(LineLayoutItem decorationObject,
+ LayoutUnit maxLogicalBottom) const;
+ LayoutUnit minLogicalTopForUnderline(LineLayoutItem decorationObject,
+ LayoutUnit minLogicalTop) const;
+
private:
void placeBoxRangeInInlineDirection(InlineBox* firstChild,
InlineBox* lastChild,
@@ -443,10 +448,6 @@ class InlineFlowBox : public InlineBox {
m_prevLineBox; // The previous box that also uses our LayoutObject
InlineFlowBox* m_nextLineBox; // The next box that also uses our LayoutObject
- // Maximum logicalTop among all children of an InlineFlowBox. Used to
- // calculate the offset for TextUnderlinePositionUnder.
- void computeMaxLogicalTop(LayoutUnit& maxLogicalTop) const;
-
private:
unsigned m_includeLogicalLeftEdge : 1;
unsigned m_includeLogicalRightEdge : 1;
« no previous file with comments | « third_party/WebKit/Source/core/layout/line/InlineBox.h ('k') | third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698