third_party/WebKit/Source/core/layout/line/RootInlineBox.h - Issue 2602793004: Fix positioning of "text-underline-position:under" for multi-elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/RootInlineBox.h

Issue 2602793004: Fix positioning of "text-underline-position:under" for multi-elements (Closed)

Patch Set: drott nit Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/RootInlineBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/RootInlineBox.h b/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

index 6bfb2964735201eeffc09c1956b073297cc9fcf0..0b92d9ad8c8e15ceddc3d405e56cece53e1d8cde 100644

--- a/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

+++ b/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

@@ -202,9 +202,6 @@ class RootInlineBox : public InlineFlowBox {

return InlineFlowBox::logicalBottomLayoutOverflow(lineBottom());

}

- // Used to calculate the underline offset for TextUnderlinePositionUnder.

- LayoutUnit maxLogicalTop() const;

Node* getLogicalStartBoxWithNode(InlineBox*&) const;

Node* getLogicalEndBoxWithNode(InlineBox*&) const;