WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

Calling this method on a generic WebFrame doesn't make sense, since it
doesn't make sense to log things to a remote frame. Some code is
apparently doing this, and spamming the CrOS logs like crazy.

BUG=416660, 667481
R=avi@chromium.org,haraken@chromium.org
TBR=rdevlin.cronin@chromium.org,thestig@chromium.org

Committed: https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c
Cr-Commit-Position: refs/heads/master@{#441029}

[dcheng, 2016-12-27 08:42:22]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 08:42:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-12-27 08:47:34]

Description was changed from

==========
WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

Calling this method on a generic WebFrame doesn't make sense, since it
doesn't make sense to log things to a remote frame. Some code is
apparently doing this, and spamming the CrOS logs like crazy.

BUG=416660,667481
==========

to

==========
WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

Calling this method on a generic WebFrame doesn't make sense, since it
doesn't make sense to log things to a remote frame. Some code is
apparently doing this, and spamming the CrOS logs like crazy.

BUG=416660,667481
==========

[dcheng, 2016-12-27 08:47:34]

dcheng@chromium.org changed reviewers:
+ avi@chromium.org, haraken@chromium.org

[dcheng, 2016-12-27 08:48:59]

+avi for non-Blink code
+haraken for Blink code

Most of this is just changing plumbing from WebFrame to WebLocalFrame, but there
are still two instances where this function is called on a generic top-level
frame. It's not clear from the code if the main frame in these situations are
local or not, so I added an if branch for now.

+michaeln, +ananta, +mlamouri as fyi / for additional insight

https://codereview.chromium.org/2601763002/diff/1/chrome/renderer/chrome_rend...
File chrome/renderer/chrome_render_view_observer.cc (right):

https://codereview.chromium.org/2601763002/diff/1/chrome/renderer/chrome_rend...
chrome/renderer/chrome_render_view_observer.cc:111:
main_frame->toWebLocalFrame()->addMessageToConsole(message);
+mlamouri... is it possible for this message to be sent to a view with a
non-local main frame? I'm guessing not, but it's not clear from how the code is
structured.

https://codereview.chromium.org/2601763002/diff/1/content/renderer/renderer_w...
File content/renderer/renderer_webapplicationcachehost_impl.cc (right):

https://codereview.chromium.org/2601763002/diff/1/content/renderer/renderer_w...
content/renderer/renderer_webapplicationcachehost_impl.cc:40: // TODO(michaeln):
Make app cache host per-frame and correctly report to the
+michaeln, +ananta since I know there's some appcache stuff happening for
plznavigate... maybe this can be addressed at that point?

[dcheng, 2016-12-27 08:53:35]

(Btw, at some point in Q1/Q2, I do plan on starting to audit all the
toLocalFrame / toWebLocalFrame type cocercions... I suspect many of these
shouldn't actually be used, and it's a matter of not having the right
abstractions)

[commit-bot: I haz the power, 2016-12-27 10:21:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 10:22:00]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-12-27 11:35:41]

LGTM

[Avi (use Gerrit), 2016-12-27 13:52:56]

lgtm

This looks reasonable to me.

[dcheng, 2016-12-27 17:33:55]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-12-27 17:34:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 17:39:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 17:39:38]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-12-30 10:08:15]

dcheng@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, thestig@chromium.org

[dcheng, 2016-12-30 10:08:54]

Description was changed from

==========
WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

Calling this method on a generic WebFrame doesn't make sense, since it
doesn't make sense to log things to a remote frame. Some code is
apparently doing this, and spamming the CrOS logs like crazy.

BUG=416660,667481
==========

to

==========
WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

Calling this method on a generic WebFrame doesn't make sense, since it
doesn't make sense to log things to a remote frame. Some code is
apparently doing this, and spamming the CrOS logs like crazy.

BUG=416660,667481
R=avi@chromium.org,haraken@chromium.org
TBR=rdevlin.cronin@chromium.org,thestig@chromium.org
==========

[dcheng, 2016-12-30 10:09:21]

TBRing rdevlin.cronin@ for extensions and thestig@ for chrome and components.

[dcheng, 2016-12-30 10:09:28]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-12-30 10:09:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-30 13:35:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483092568057570, "parent_rev":
"a6ceb422b41593d70b2c4366d490a226db35cda1", "commit_rev":
"49b9e7554a552e0486a5be082dc15aab1598fc36"}

[commit-bot: I haz the power, 2016-12-30 13:35:40]

Description was changed from

==========
WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

Calling this method on a generic WebFrame doesn't make sense, since it
doesn't make sense to log things to a remote frame. Some code is
apparently doing this, and spamming the CrOS logs like crazy.

BUG=416660,667481
R=avi@chromium.org,haraken@chromium.org
TBR=rdevlin.cronin@chromium.org,thestig@chromium.org
==========

to

==========
WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

Calling this method on a generic WebFrame doesn't make sense, since it
doesn't make sense to log things to a remote frame. Some code is
apparently doing this, and spamming the CrOS logs like crazy.

BUG=416660,667481
R=avi@chromium.org,haraken@chromium.org
TBR=rdevlin.cronin@chromium.org,thestig@chromium.org

Review-Url: https://codereview.chromium.org/2601763002
==========

[commit-bot: I haz the power, 2016-12-30 13:35:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:54:29]

Description was changed from

==========
WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

Calling this method on a generic WebFrame doesn't make sense, since it
doesn't make sense to log things to a remote frame. Some code is
apparently doing this, and spamming the CrOS logs like crazy.

BUG=416660,667481
R=avi@chromium.org,haraken@chromium.org
TBR=rdevlin.cronin@chromium.org,thestig@chromium.org

Review-Url: https://codereview.chromium.org/2601763002
==========

to

==========
WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

Calling this method on a generic WebFrame doesn't make sense, since it
doesn't make sense to log things to a remote frame. Some code is
apparently doing this, and spamming the CrOS logs like crazy.

BUG=416660,667481
R=avi@chromium.org,haraken@chromium.org
TBR=rdevlin.cronin@chromium.org,thestig@chromium.org

Committed: https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c
Cr-Commit-Position: refs/heads/master@{#441029}
==========

[commit-bot: I haz the power, 2017-01-02 15:54:30]

Patchset 1 (id:??) landed as
https://crrev.com/5a2307c7dd371719a6f21aa919efa9ce607e3f4c
Cr-Commit-Position: refs/heads/master@{#441029}

[Devlin, 2017-01-02 16:40:29]

extensions retro lgtm

[Lei Zhang, 2017-02-23 22:16:55]

On 2016/12/30 10:09:21, dcheng wrote:
> TBRing rdevlin.cronin@ for extensions and thestig@ for chrome and components.

lgtm

[Lei Zhang, 2017-02-23 22:16:55]

On 2016/12/30 10:09:21, dcheng wrote:
> TBRing rdevlin.cronin@ for extensions and thestig@ for chrome and components.

lgtm