WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

chrome/renderer/chrome_render_view_observer.cc

Index: chrome/renderer/chrome_render_view_observer.cc
diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc
index b90084854a7afb4800af674e0a94831f41884919..f8f35743559d77c001b2288cde390cc59b60c1ce 100644
--- a/chrome/renderer/chrome_render_view_observer.cc
+++ b/chrome/renderer/chrome_render_view_observer.cc
@@ -98,15 +98,17 @@ void ChromeRenderViewObserver::OnGetWebApplicationInfo() {
 
   // The warning below is specific to mobile but it doesn't hurt to show it even
   // if the Chromium build is running on a desktop. It will get more exposition.
-  if (web_app_info.mobile_capable ==
-        WebApplicationInfo::MOBILE_CAPABLE_APPLE) {
+  // TODO(mlamouri): Associate this message with an actual frame, to avoid the
+  // need to check whether or not the main frame is local.
+  if (web_app_info.mobile_capable == WebApplicationInfo::MOBILE_CAPABLE_APPLE &&
+      main_frame->isWebLocalFrame()) {
     blink::WebConsoleMessage message(
         blink::WebConsoleMessage::LevelWarning,
         "<meta name=\"apple-mobile-web-app-capable\" content=\"yes\"> is "
         "deprecated. Please include <meta name=\"mobile-web-app-capable\" "
         "content=\"yes\"> - "
         "http://developers.google.com/chrome/mobile/docs/installtohomescreen");
-    main_frame->addMessageToConsole(message);
+    main_frame->toWebLocalFrame()->addMessageToConsole(message);

[dcheng, 2016/12/27 08:48:59]

+mlamouri... is it possible for this message to be sent to a view with a
non-local main frame? I'm guessing not, but it's not clear from how the code is
structured.

   }
 
   // Prune out any data URLs in the set of icons.  The browser process expects