Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2601763002: WebFrame cleanup: Move addMessageToConsole to WebLocalFrame (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index 75a82ab802165287b217de6fc2b4840b314dfe58..2bb92168426e5f9f140e765e5a9aab8dca4db847 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -911,13 +911,14 @@ DOMWindow* ChromeClientImpl::pagePopupWindowForTesting() const {
}
bool ChromeClientImpl::shouldOpenModalDialogDuringPageDismissal(
- const DialogType& dialogType,
+ LocalFrame& frame,
+ DialogType dialogType,
const String& dialogMessage,
Document::PageDismissalType dismissalType) const {
String message = String("Blocked ") + dialogTypeToString(dialogType) + "('" +
dialogMessage + "') during " +
dismissalTypeToString(dismissalType) + ".";
- m_webView->mainFrame()->addMessageToConsole(
+ WebLocalFrameImpl::fromFrame(frame)->addMessageToConsole(
WebConsoleMessage(WebConsoleMessage::LevelError, message));
return false;

Powered by Google App Engine
This is Rietveld 408576698