Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.cpp

Issue 2601763002: WebFrame cleanup: Move addMessageToConsole to WebLocalFrame (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/ChromeClient.cpp
diff --git a/third_party/WebKit/Source/core/page/ChromeClient.cpp b/third_party/WebKit/Source/core/page/ChromeClient.cpp
index 05238fe1cbbfb262c462aad2cbaf99cee8da6f50..0722386ff3d352bc587e7520346c1acf7da69b34 100644
--- a/third_party/WebKit/Source/core/page/ChromeClient.cpp
+++ b/third_party/WebKit/Source/core/page/ChromeClient.cpp
@@ -68,11 +68,13 @@ bool ChromeClient::canOpenModalIfDuringPageDismissal(
for (Frame* frame = mainFrame; frame; frame = frame->tree().traverseNext()) {
if (!frame->isLocalFrame())
continue;
+ LocalFrame& localFrame = toLocalFrame(*frame);
Document::PageDismissalType dismissal =
- toLocalFrame(frame)->document()->pageDismissalEventBeingDispatched();
- if (dismissal != Document::NoDismissal)
- return shouldOpenModalDialogDuringPageDismissal(dialog, message,
- dismissal);
+ localFrame.document()->pageDismissalEventBeingDispatched();
+ if (dismissal != Document::NoDismissal) {
+ return shouldOpenModalDialogDuringPageDismissal(localFrame, dialog,
+ message, dismissal);
+ }
}
return true;
}

Powered by Google App Engine
This is Rietveld 408576698