third_party/WebKit/Source/core/page/ChromeClient.h - Issue 2601763002: WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 2601763002: WebFrame cleanup: Move addMessageToConsole to WebLocalFrame (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/ChromeClient.h

diff --git a/third_party/WebKit/Source/core/page/ChromeClient.h b/third_party/WebKit/Source/core/page/ChromeClient.h

index 46510033a27f038f44c13c8de13248865c16f894..7ddb77859e06b5fbcf0afe939ea0cd4f6088d8a8 100644

--- a/third_party/WebKit/Source/core/page/ChromeClient.h

+++ b/third_party/WebKit/Source/core/page/ChromeClient.h

@@ -279,7 +279,8 @@ class CORE_EXPORT ChromeClient : public HostWindow {

HTMLDialog = 3

};

virtual bool shouldOpenModalDialogDuringPageDismissal(

- const DialogType&,

+ LocalFrame&,

+ DialogType,

const String&,

Document::PageDismissalType) const {

return true;