Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Side by Side Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 2601763002: WebFrame cleanup: Move addMessageToConsole to WebLocalFrame (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebLocalFrame_h 5 #ifndef WebLocalFrame_h
6 #define WebLocalFrame_h 6 #define WebLocalFrame_h
7 7
8 #include "WebCompositionUnderline.h" 8 #include "WebCompositionUnderline.h"
9 #include "WebFrame.h" 9 #include "WebFrame.h"
10 #include "WebFrameLoadType.h" 10 #include "WebFrameLoadType.h"
(...skipping 13 matching lines...) Expand all
24 class WebDevToolsAgent; 24 class WebDevToolsAgent;
25 class WebDevToolsAgentClient; 25 class WebDevToolsAgentClient;
26 class WebDoubleSize; 26 class WebDoubleSize;
27 class WebFrameClient; 27 class WebFrameClient;
28 class WebFrameWidget; 28 class WebFrameWidget;
29 class WebRange; 29 class WebRange;
30 class WebScriptExecutionCallback; 30 class WebScriptExecutionCallback;
31 enum class WebCachePolicy; 31 enum class WebCachePolicy;
32 enum class WebSandboxFlags; 32 enum class WebSandboxFlags;
33 enum class WebTreeScopeType; 33 enum class WebTreeScopeType;
34 struct WebConsoleMessage;
34 struct WebFindOptions; 35 struct WebFindOptions;
35 struct WebFloatRect; 36 struct WebFloatRect;
36 struct WebPrintPresetOptions; 37 struct WebPrintPresetOptions;
37 38
38 // Interface for interacting with in process frames. This contains methods that 39 // Interface for interacting with in process frames. This contains methods that
39 // require interacting with a frame's document. 40 // require interacting with a frame's document.
40 // FIXME: Move lots of methods from WebFrame in here. 41 // FIXME: Move lots of methods from WebFrame in here.
41 class WebLocalFrame : public WebFrame { 42 class WebLocalFrame : public WebFrame {
42 public: 43 public:
43 // Creates a WebFrame. Delete this WebFrame by calling WebFrame::close(). 44 // Creates a WebFrame. Delete this WebFrame by calling WebFrame::close().
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 unsigned numSources, 220 unsigned numSources,
220 int extensionGroup, 221 int extensionGroup,
221 bool userGesture, 222 bool userGesture,
222 WebScriptExecutionCallback*) = 0; 223 WebScriptExecutionCallback*) = 0;
223 224
224 // Associates an isolated world with human-readable name which is useful for 225 // Associates an isolated world with human-readable name which is useful for
225 // extension debugging. 226 // extension debugging.
226 virtual void setIsolatedWorldHumanReadableName(int worldID, 227 virtual void setIsolatedWorldHumanReadableName(int worldID,
227 const WebString&) = 0; 228 const WebString&) = 0;
228 229
230 // Logs to the console associated with this frame.
231 virtual void addMessageToConsole(const WebConsoleMessage&) = 0;
232
229 // Editing ------------------------------------------------------------- 233 // Editing -------------------------------------------------------------
230 234
231 virtual void setMarkedText(const WebString& text, 235 virtual void setMarkedText(const WebString& text,
232 unsigned location, 236 unsigned location,
233 unsigned length) = 0; 237 unsigned length) = 0;
234 virtual void unmarkText() = 0; 238 virtual void unmarkText() = 0;
235 virtual bool hasMarkedText() const = 0; 239 virtual bool hasMarkedText() const = 0;
236 240
237 virtual WebRange markedRange() const = 0; 241 virtual WebRange markedRange() const = 0;
238 242
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 // to call these on a WebLocalFrame. 466 // to call these on a WebLocalFrame.
463 bool isWebLocalFrame() const override = 0; 467 bool isWebLocalFrame() const override = 0;
464 WebLocalFrame* toWebLocalFrame() override = 0; 468 WebLocalFrame* toWebLocalFrame() override = 0;
465 bool isWebRemoteFrame() const override = 0; 469 bool isWebRemoteFrame() const override = 0;
466 WebRemoteFrame* toWebRemoteFrame() override = 0; 470 WebRemoteFrame* toWebRemoteFrame() override = 0;
467 }; 471 };
468 472
469 } // namespace blink 473 } // namespace blink
470 474
471 #endif // WebLocalFrame_h 475 #endif // WebLocalFrame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698