WebFrame cleanup: Move addMessageToConsole to WebLocalFrame

chrome/renderer/chrome_render_view_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_render_view_observer.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 80 matching lines @@
 
 void ChromeRenderViewObserver::OnGetWebApplicationInfo() {
   WebFrame* main_frame = render_view()->GetWebView()->mainFrame();
   DCHECK(main_frame);
 
   WebApplicationInfo web_app_info;
   web_apps::ParseWebAppFromWebDocument(main_frame, &web_app_info);
 
   // The warning below is specific to mobile but it doesn't hurt to show it even
   // if the Chromium build is running on a desktop. It will get more exposition.
-  if (web_app_info.mobile_capable ==
-        WebApplicationInfo::MOBILE_CAPABLE_APPLE) {
+  // TODO(mlamouri): Associate this message with an actual frame, to avoid the
+  // need to check whether or not the main frame is local.
+  if (web_app_info.mobile_capable == WebApplicationInfo::MOBILE_CAPABLE_APPLE &&
+      main_frame->isWebLocalFrame()) {
     blink::WebConsoleMessage message(
         blink::WebConsoleMessage::LevelWarning,
         "<meta name=\"apple-mobile-web-app-capable\" content=\"yes\"> is "
         "deprecated. Please include <meta name=\"mobile-web-app-capable\" "
         "content=\"yes\"> - "
         "http://developers.google.com/chrome/mobile/docs/installtohomescreen");
-    main_frame->addMessageToConsole(message);
+    main_frame->toWebLocalFrame()->addMessageToConsole(message);

[dcheng, 2016/12/27 08:48:59]

+mlamouri... is it possible for this message to be sent to a view with a
non-local main frame? I'm guessing not, but it's not clear from how the code is
structured.

   }
 
   // Prune out any data URLs in the set of icons.  The browser process expects
   // any icon with a data URL to have originated from a favicon.  We don't want
   // to decode arbitrary data URLs in the browser process.  See
   // http://b/issue?id=1162972
   for (std::vector<WebApplicationInfo::IconInfo>::iterator it =
           web_app_info.icons.begin(); it != web_app_info.icons.end();) {
     if (it->url.SchemeIs(url::kDataScheme))
       it = web_app_info.icons.erase(it);
@@ skipping 47 matching lines @@
       !webui_javascript_.empty()) {
     for (const auto& script : webui_javascript_)
       render_view()->GetMainRenderFrame()->ExecuteJavaScript(script);
     webui_javascript_.clear();
   }
 }
 
 void ChromeRenderViewObserver::OnDestruct() {
   delete this;
 }