Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1441)

Unified Diff: net/quic/core/quic_headers_stream_test.cc

Issue 2580393003: Replace QuicAckListenerInterface* with scoped_refptr<QuicAckListenerInterface>. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_headers_stream.cc ('k') | net/quic/core/quic_packet_creator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_headers_stream_test.cc
diff --git a/net/quic/core/quic_headers_stream_test.cc b/net/quic/core/quic_headers_stream_test.cc
index 65727a1c069f82c449512f5c5c6bee06c47fd9f1..f8d9eb6bfc25f318b37bb3568b4f796cda9280cf 100644
--- a/net/quic/core/quic_headers_stream_test.cc
+++ b/net/quic/core/quic_headers_stream_test.cc
@@ -264,7 +264,7 @@ class QuicHeadersStreamTest : public ::testing::TestWithParam<TestParamsTuple> {
QuicConsumedData SaveIovAndNotifyAckListener(
const QuicIOVector& data,
- QuicAckListenerInterface* ack_listener) {
+ const scoped_refptr<QuicAckListenerInterface>& ack_listener) {
QuicConsumedData result = SaveIov(data);
if (ack_listener) {
ack_listener->OnPacketAcked(result.bytes_consumed,
@@ -324,8 +324,8 @@ class QuicHeadersStreamTest : public ::testing::TestWithParam<TestParamsTuple> {
SpdyPriority priority,
bool is_request) {
// Write the headers and capture the outgoing data
- EXPECT_CALL(session_, WritevData(headers_stream_, kHeadersStreamId, _, _,
- false, nullptr))
+ EXPECT_CALL(session_,
+ WritevData(headers_stream_, kHeadersStreamId, _, _, false, _))
.WillOnce(WithArgs<2>(Invoke(this, &QuicHeadersStreamTest::SaveIov)));
headers_stream_->WriteHeaders(stream_id, headers_.Clone(), fin, priority,
nullptr);
@@ -443,8 +443,8 @@ TEST_P(QuicHeadersStreamTest, WritePushPromises) {
QuicStreamId promised_stream_id = NextPromisedStreamId();
if (perspective() == Perspective::IS_SERVER) {
// Write the headers and capture the outgoing data
- EXPECT_CALL(session_, WritevData(headers_stream_, kHeadersStreamId, _, _,
- false, nullptr))
+ EXPECT_CALL(session_,
+ WritevData(headers_stream_, kHeadersStreamId, _, _, false, _))
.WillOnce(WithArgs<2>(Invoke(this, &QuicHeadersStreamTest::SaveIov)));
headers_stream_->WritePushPromise(stream_id, promised_stream_id,
headers_.Clone());
@@ -963,7 +963,7 @@ TEST_P(QuicHeadersStreamTest, WritevStreamData) {
this, &QuicHeadersStreamTest::SaveIovAndNotifyAckListener)));
QuicConsumedData consumed_data = headers_stream_->WritevStreamData(
- id, MakeIOVector(data, &iov), offset, fin, ack_listener.get());
+ id, MakeIOVector(data, &iov), offset, fin, ack_listener);
EXPECT_EQ(consumed_data.bytes_consumed, data_len);
EXPECT_EQ(consumed_data.fin_consumed, fin);
« no previous file with comments | « net/quic/core/quic_headers_stream.cc ('k') | net/quic/core/quic_packet_creator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698