net/quic/core/quic_session.cc - Issue 2580393003: Replace QuicAckListenerInterface* with scoped_refptr<QuicAckListenerInterface>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/quic_session.cc

Issue 2580393003: Replace QuicAckListenerInterface* with scoped_refptr<QuicAckListenerInterface>. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/core/quic_session.cc

diff --git a/net/quic/core/quic_session.cc b/net/quic/core/quic_session.cc

index 4762222b22b11de45681a4385c81e44a7649d341..b4a69dd7606748fb03de3245e3681690f81780d9 100644

--- a/net/quic/core/quic_session.cc

+++ b/net/quic/core/quic_session.cc

@@ -283,7 +283,7 @@ QuicConsumedData QuicSession::WritevData(

QuicIOVector iov,

QuicStreamOffset offset,

bool fin,

- QuicAckListenerInterface* ack_notifier_delegate) {

+ const scoped_refptr<QuicAckListenerInterface>& ack_notifier_delegate) {

// This check is an attempt to deal with potential memory corruption

// in which |id| ends up set to 1 (the crypto stream id). If this happen

// it might end up resulting in unencrypted stream data being sent.

« no previous file with comments | « net/quic/core/quic_session.h ('k') | net/quic/core/quic_session_test.cc » ('j') | no next file with comments »