Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: net/quic/core/quic_packet_generator.cc

Issue 2580393003: Replace QuicAckListenerInterface* with scoped_refptr<QuicAckListenerInterface>. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_packet_generator.h ('k') | net/quic/core/quic_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_packet_generator.cc
diff --git a/net/quic/core/quic_packet_generator.cc b/net/quic/core/quic_packet_generator.cc
index fc7bbbb67be186c368e6bb21378a8b7591d3386f..a46f72c6d96995accb0e19e1f851462528fd0322 100644
--- a/net/quic/core/quic_packet_generator.cc
+++ b/net/quic/core/quic_packet_generator.cc
@@ -53,7 +53,7 @@ QuicConsumedData QuicPacketGenerator::ConsumeData(
QuicIOVector iov,
QuicStreamOffset offset,
bool fin,
- QuicAckListenerInterface* listener) {
+ const scoped_refptr<QuicAckListenerInterface>& listener) {
bool has_handshake = (id == kCryptoStreamId);
QUIC_BUG_IF(has_handshake && fin)
<< "Handshake packets should never send a fin";
@@ -125,7 +125,7 @@ QuicConsumedData QuicPacketGenerator::ConsumeDataFastPath(
const QuicIOVector& iov,
QuicStreamOffset offset,
bool fin,
- QuicAckListenerInterface* listener) {
+ const scoped_refptr<QuicAckListenerInterface>& listener) {
DCHECK_NE(id, kCryptoStreamId);
size_t total_bytes_consumed = 0;
while (total_bytes_consumed < iov.total_length &&
@@ -145,7 +145,7 @@ QuicConsumedData QuicPacketGenerator::ConsumeDataFastPath(
void QuicPacketGenerator::GenerateMtuDiscoveryPacket(
QuicByteCount target_mtu,
- QuicAckListenerInterface* listener) {
+ const scoped_refptr<QuicAckListenerInterface>& listener) {
// MTU discovery frames must be sent by themselves.
if (!packet_creator_.CanSetMaxPacketLength()) {
QUIC_BUG << "MTU discovery packets should only be sent when no other "
« no previous file with comments | « net/quic/core/quic_packet_generator.h ('k') | net/quic/core/quic_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698