Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: net/quic/chromium/quic_chromium_client_stream_test.cc

Issue 2580393003: Replace QuicAckListenerInterface* with scoped_refptr<QuicAckListenerInterface>. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_chromium_client_stream.cc ('k') | net/quic/core/quic_ack_listener_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_chromium_client_stream_test.cc
diff --git a/net/quic/chromium/quic_chromium_client_stream_test.cc b/net/quic/chromium/quic_chromium_client_stream_test.cc
index 975fb0c4e66e4d018f549f82b0764cb7600a37e8..075e85492a91657d920b88203401de9d5a21f121 100644
--- a/net/quic/chromium/quic_chromium_client_stream_test.cc
+++ b/net/quic/chromium/quic_chromium_client_stream_test.cc
@@ -79,13 +79,14 @@ class MockQuicClientSessionBase : public QuicClientSessionBase {
MOCK_METHOD1(CreateIncomingDynamicStream, QuicSpdyStream*(QuicStreamId id));
MOCK_METHOD1(CreateOutgoingDynamicStream,
QuicChromiumClientStream*(SpdyPriority priority));
- MOCK_METHOD6(WritevData,
- QuicConsumedData(QuicStream* stream,
- QuicStreamId id,
- QuicIOVector data,
- QuicStreamOffset offset,
- bool fin,
- QuicAckListenerInterface*));
+ MOCK_METHOD6(
+ WritevData,
+ QuicConsumedData(QuicStream* stream,
+ QuicStreamId id,
+ QuicIOVector data,
+ QuicStreamOffset offset,
+ bool fin,
+ const scoped_refptr<QuicAckListenerInterface>&));
MOCK_METHOD3(SendRstStream,
void(QuicStreamId stream_id,
QuicRstStreamErrorCode error,
@@ -106,12 +107,12 @@ class MockQuicClientSessionBase : public QuicClientSessionBase {
MOCK_METHOD0(IsCryptoHandshakeConfirmed, bool());
// Methods taking non-copyable types like SpdyHeaderBlock by value cannot be
// mocked directly.
- size_t WriteHeaders(
- QuicStreamId id,
- SpdyHeaderBlock headers,
- bool fin,
- SpdyPriority priority,
- QuicAckListenerInterface* ack_notifier_delegate) override {
+ size_t WriteHeaders(QuicStreamId id,
+ SpdyHeaderBlock headers,
+ bool fin,
+ SpdyPriority priority,
+ const scoped_refptr<QuicAckListenerInterface>&
+ ack_notifier_delegate) override {
return WriteHeadersMock(id, headers, fin, priority, ack_notifier_delegate);
}
MOCK_METHOD5(WriteHeadersMock,
@@ -119,7 +120,8 @@ class MockQuicClientSessionBase : public QuicClientSessionBase {
const SpdyHeaderBlock& headers,
bool fin,
SpdyPriority priority,
- QuicAckListenerInterface* ack_notifier_delegate));
+ const scoped_refptr<QuicAckListenerInterface>&
+ ack_notifier_delegate));
MOCK_METHOD1(OnHeadersHeadOfLineBlocking, void(QuicTime::Delta delta));
using QuicSession::ActivateStream;
« no previous file with comments | « net/quic/chromium/quic_chromium_client_stream.cc ('k') | net/quic/core/quic_ack_listener_interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698