Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: net/quic/core/quic_headers_stream.h

Issue 2580393003: Replace QuicAckListenerInterface* with scoped_refptr<QuicAckListenerInterface>. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_connection_test.cc ('k') | net/quic/core/quic_headers_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_headers_stream.h
diff --git a/net/quic/core/quic_headers_stream.h b/net/quic/core/quic_headers_stream.h
index 4c7885c92b9b30bad613950e1bcdb5e02a47bccd..2c2b6dcd8a3e7e79398ea9fd65ef411f29fec4af 100644
--- a/net/quic/core/quic_headers_stream.h
+++ b/net/quic/core/quic_headers_stream.h
@@ -51,11 +51,12 @@ class QUIC_EXPORT_PRIVATE QuicHeadersStream : public QuicStream {
// Writes |headers| for |stream_id| in an HTTP/2 HEADERS frame to the peer.
// If |fin| is true, the fin flag will be set on the HEADERS frame. Returns
// the size, in bytes, of the resulting HEADERS frame.
- virtual size_t WriteHeaders(QuicStreamId stream_id,
- SpdyHeaderBlock headers,
- bool fin,
- SpdyPriority priority,
- QuicAckListenerInterface* ack_listener);
+ virtual size_t WriteHeaders(
+ QuicStreamId stream_id,
+ SpdyHeaderBlock headers,
+ bool fin,
+ SpdyPriority priority,
+ const scoped_refptr<QuicAckListenerInterface>& ack_listener);
// Write |headers| for |promised_stream_id| on |original_stream_id| in a
// PUSH_PROMISE frame to peer.
@@ -71,7 +72,7 @@ class QUIC_EXPORT_PRIVATE QuicHeadersStream : public QuicStream {
QuicIOVector iov,
QuicStreamOffset offset,
bool fin,
- QuicAckListenerInterface* ack_notifier_delegate);
+ const scoped_refptr<QuicAckListenerInterface>& ack_notifier_delegate);
// QuicStream implementation
void OnDataAvailable() override;
@@ -140,10 +141,11 @@ class QUIC_EXPORT_PRIVATE QuicHeadersStream : public QuicStream {
bool OnDataFrameHeader(QuicStreamId stream_id, size_t length, bool fin);
bool OnStreamFrameData(QuicStreamId stream_id, const char* data, size_t len);
// Helper for |WritevStreamData()|.
- void WriteDataFrame(QuicStreamId stream_id,
- base::StringPiece data,
- bool fin,
- QuicAckListenerInterface* ack_notifier_delegate);
+ void WriteDataFrame(
+ QuicStreamId stream_id,
+ base::StringPiece data,
+ bool fin,
+ const scoped_refptr<QuicAckListenerInterface>& ack_notifier_delegate);
// Returns true if the session is still connected.
bool IsConnected();
« no previous file with comments | « net/quic/core/quic_connection_test.cc ('k') | net/quic/core/quic_headers_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698