Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2572563004: Improve the casing of Stackmap and Stacktrace. (Closed)

Created:
4 years ago by Cutch
Modified:
4 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve the casing of Stackmap and Stacktrace. - [x] Stackmap -> StackMap - [x] Stacktrace -> StackTrace This makes us consistent with the Dart language (StackTrace) and corrects the casing of StackMap. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f125cc7d0ba46473585f55cbc809c7c8c42ea16a

Patch Set 1 #

Patch Set 2 : Build fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -295 lines) Patch
M runtime/bin/run_vm_tests_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/include/dart_api.h View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/object.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/stacktrace.h View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/lib/stacktrace.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/notify_exception.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/ui/inspector.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bitmap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/bitmap_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 11 chunks +23 lines, -23 lines 0 comments Download
M runtime/vm/code_descriptors.h View 3 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/code_descriptors.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/code_descriptors_test.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M runtime/vm/dart_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/disassembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/exceptions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/exceptions.cc View 12 chunks +31 lines, -31 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 10 chunks +15 lines, -15 lines 0 comments Download
M runtime/vm/object.cc View 19 chunks +48 lines, -48 lines 0 comments Download
M runtime/vm/object_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object_store.h View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object_store.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/object_test.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/precompiler.h View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/precompiler.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M runtime/vm/raw_object.h View 5 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/raw_object.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/simulator_dbc.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot.h View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years ago (2016-12-12 22:42:33 UTC) #3
rmacnak
lgtm
4 years ago (2016-12-12 22:48:30 UTC) #4
Cutch
4 years ago (2016-12-12 22:51:36 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f125cc7d0ba46473585f55cbc809c7c8c42ea16a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698