Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: runtime/observatory/lib/src/elements/nav/notify_exception.dart

Issue 2572563004: Improve the casing of Stackmap and Stacktrace. (Closed)
Patch Set: Build fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/stacktrace.cc ('k') | runtime/observatory/tests/ui/inspector.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:html'; 5 import 'dart:html';
6 import 'dart:async'; 6 import 'dart:async';
7 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart'; 7 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
8 import 'package:observatory/src/elements/helpers/tag.dart'; 8 import 'package:observatory/src/elements/helpers/tag.dart';
9 import 'package:observatory/src/elements/helpers/uris.dart'; 9 import 'package:observatory/src/elements/helpers/uris.dart';
10 import 'package:observatory/models.dart' show ConnectionException; 10 import 'package:observatory/models.dart' show ConnectionException;
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 List<Node> content; 91 List<Node> content;
92 content = [ 92 content = [
93 new SpanElement()..text = 'Unexpected exception:', 93 new SpanElement()..text = 'Unexpected exception:',
94 new BRElement(), 94 new BRElement(),
95 new BRElement(), 95 new BRElement(),
96 new DivElement()..text = exception.toString(), 96 new DivElement()..text = exception.toString(),
97 new BRElement() 97 new BRElement()
98 ]; 98 ];
99 if (stacktrace != null) { 99 if (stacktrace != null) {
100 content.addAll([ 100 content.addAll([
101 new SpanElement()..text = 'Stacktrace:', 101 new SpanElement()..text = 'StackTrace:',
102 new BRElement(), 102 new BRElement(),
103 new BRElement(), 103 new BRElement(),
104 new DivElement()..text = stacktrace.toString(), 104 new DivElement()..text = stacktrace.toString(),
105 new BRElement() 105 new BRElement()
106 ]); 106 ]);
107 } 107 }
108 content.addAll([ 108 content.addAll([
109 new SpanElement()..text = '[', 109 new SpanElement()..text = '[',
110 new AnchorElement(href: Uris.vmConnect()) 110 new AnchorElement(href: Uris.vmConnect())
111 ..text = 'Connect to a different VM', 111 ..text = 'Connect to a different VM',
(...skipping 10 matching lines...) Expand all
122 } 122 }
123 123
124 void _delete(ExceptionDeleteEvent e) { 124 void _delete(ExceptionDeleteEvent e) {
125 _onDelete.add(e); 125 _onDelete.add(e);
126 } 126 }
127 127
128 void delete() { 128 void delete() {
129 _onDelete.add(new ExceptionDeleteEvent(exception, stacktrace: stacktrace)); 129 _onDelete.add(new ExceptionDeleteEvent(exception, stacktrace: stacktrace));
130 } 130 }
131 } 131 }
OLDNEW
« no previous file with comments | « runtime/lib/stacktrace.cc ('k') | runtime/observatory/tests/ui/inspector.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698