Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: runtime/vm/raw_object.h

Issue 2572563004: Improve the casing of Stackmap and Stacktrace. (Closed)
Patch Set: Build fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/raw_object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.h
diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h
index 532cb72b7038a4d5b65fbae1a6f1f14bd3740c25..25a54b802b36f1b7377307a2f5587d4c704411a8 100644
--- a/runtime/vm/raw_object.h
+++ b/runtime/vm/raw_object.h
@@ -34,7 +34,7 @@ namespace dart {
V(ObjectPool) \
V(PcDescriptors) \
V(CodeSourceMap) \
- V(Stackmap) \
+ V(StackMap) \
V(LocalVarDescriptors) \
V(ExceptionHandlers) \
V(Context) \
@@ -74,7 +74,7 @@ namespace dart {
V(Capability) \
V(ReceivePort) \
V(SendPort) \
- V(Stacktrace) \
+ V(StackTrace) \
V(RegExp) \
V(WeakProperty) \
V(MirrorReference) \
@@ -1268,14 +1268,14 @@ class RawCodeSourceMap : public RawObject {
};
-// Stackmap is an immutable representation of the layout of the stack at a
+// StackMap is an immutable representation of the layout of the stack at a
// PC. The stack map representation consists of a bit map which marks each
// live object index starting from the base of the frame.
//
// The bit map representation is optimized for dense and small bit maps, without
// any upper bound.
-class RawStackmap : public RawObject {
- RAW_HEAP_OBJECT_IMPLEMENTATION(Stackmap);
+class RawStackMap : public RawObject {
+ RAW_HEAP_OBJECT_IMPLEMENTATION(StackMap);
// Regarding changing this to a bitfield: ARM64 requires register_bit_count_
// to be as large as 96, meaning 7 bits, leaving 25 bits for the length, or
@@ -2099,8 +2099,8 @@ class RawReceivePort : public RawInstance {
// Currently we don't have any interface that this object is supposed
// to implement so we just support the 'toString' method which
// converts the stack trace into a string.
-class RawStacktrace : public RawInstance {
- RAW_HEAP_OBJECT_IMPLEMENTATION(Stacktrace);
+class RawStackTrace : public RawInstance {
+ RAW_HEAP_OBJECT_IMPLEMENTATION(StackTrace);
RawObject** from() {
return reinterpret_cast<RawObject**>(&ptr()->code_array_);
@@ -2378,7 +2378,7 @@ inline bool RawObject::IsVariableSizeClassId(intptr_t index) {
RawObject::IsTypedDataClassId(index) || (index == kContextCid) ||
(index == kTypeArgumentsCid) || (index == kInstructionsCid) ||
(index == kObjectPoolCid) || (index == kPcDescriptorsCid) ||
- (index == kCodeSourceMapCid) || (index == kStackmapCid) ||
+ (index == kCodeSourceMapCid) || (index == kStackMapCid) ||
(index == kLocalVarDescriptorsCid) ||
(index == kExceptionHandlersCid) || (index == kCodeCid) ||
(index == kContextScopeCid) || (index == kInstanceCid) ||
« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/raw_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698