Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: runtime/vm/object_test.cc

Issue 2572563004: Improve the casing of Stackmap and Stacktrace. (Closed)
Patch Set: Build fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_store.cc ('k') | runtime/vm/parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc
index c0ac1ad6764b8d76e4e84b0bcc8c2f8f42b63171..667280aa45188fcca68f1accf0e1315d0ef9b5ea 100644
--- a/runtime/vm/object_test.cc
+++ b/runtime/vm/object_test.cc
@@ -2789,12 +2789,12 @@ VM_TEST_CASE(ExceptionHandlers) {
// Add an exception handler table to the code.
ExceptionHandlers& exception_handlers = ExceptionHandlers::Handle();
exception_handlers ^= ExceptionHandlers::New(kNumEntries);
- const bool kNeedsStacktrace = true;
- const bool kNoStacktrace = false;
- exception_handlers.SetHandlerInfo(0, -1, 20u, kNeedsStacktrace, false);
- exception_handlers.SetHandlerInfo(1, 0, 30u, kNeedsStacktrace, false);
- exception_handlers.SetHandlerInfo(2, -1, 40u, kNoStacktrace, true);
- exception_handlers.SetHandlerInfo(3, 1, 150u, kNoStacktrace, true);
+ const bool kNeedsStackTrace = true;
+ const bool kNoStackTrace = false;
+ exception_handlers.SetHandlerInfo(0, -1, 20u, kNeedsStackTrace, false);
+ exception_handlers.SetHandlerInfo(1, 0, 30u, kNeedsStackTrace, false);
+ exception_handlers.SetHandlerInfo(2, -1, 40u, kNoStackTrace, true);
+ exception_handlers.SetHandlerInfo(3, 1, 150u, kNoStackTrace, true);
extern void GenerateIncrement(Assembler * assembler);
Assembler _assembler_;
@@ -2812,12 +2812,12 @@ VM_TEST_CASE(ExceptionHandlers) {
EXPECT_EQ(-1, handlers.OuterTryIndex(0));
EXPECT_EQ(-1, info.outer_try_index);
EXPECT_EQ(20u, handlers.HandlerPCOffset(0));
- EXPECT(handlers.NeedsStacktrace(0));
+ EXPECT(handlers.NeedsStackTrace(0));
EXPECT(!handlers.HasCatchAll(0));
EXPECT_EQ(20u, info.handler_pc_offset);
EXPECT_EQ(1, handlers.OuterTryIndex(3));
EXPECT_EQ(150u, handlers.HandlerPCOffset(3));
- EXPECT(!handlers.NeedsStacktrace(3));
+ EXPECT(!handlers.NeedsStackTrace(3));
EXPECT(handlers.HasCatchAll(3));
}
« no previous file with comments | « runtime/vm/object_store.cc ('k') | runtime/vm/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698