Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: runtime/lib/stacktrace.cc

Issue 2572563004: Improve the casing of Stackmap and Stacktrace. (Closed)
Patch Set: Build fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/stacktrace.h ('k') | runtime/observatory/lib/src/elements/nav/notify_exception.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/stacktrace.cc
diff --git a/runtime/lib/stacktrace.cc b/runtime/lib/stacktrace.cc
index dcc48348bb8dbec915f7c56777804fb7e4669005..d7dcfe01f2e4e81ac1c21632bff21caef543b435 100644
--- a/runtime/lib/stacktrace.cc
+++ b/runtime/lib/stacktrace.cc
@@ -34,10 +34,10 @@ static void IterateFrames(const GrowableObjectArray& code_list,
}
}
-// Creates a Stacktrace object from the current stack.
+// Creates a StackTrace object from the current stack.
//
// Skips the first skip_frames Dart frames.
-const Stacktrace& GetCurrentStacktrace(int skip_frames) {
+const StackTrace& GetCurrentStackTrace(int skip_frames) {
const GrowableObjectArray& code_list =
GrowableObjectArray::Handle(GrowableObjectArray::New());
const GrowableObjectArray& pc_offset_list =
@@ -46,8 +46,8 @@ const Stacktrace& GetCurrentStacktrace(int skip_frames) {
const Array& code_array = Array::Handle(Array::MakeArray(code_list));
const Array& pc_offset_array =
Array::Handle(Array::MakeArray(pc_offset_list));
- const Stacktrace& stacktrace =
- Stacktrace::Handle(Stacktrace::New(code_array, pc_offset_array));
+ const StackTrace& stacktrace =
+ StackTrace::Handle(StackTrace::New(code_array, pc_offset_array));
return stacktrace;
}
@@ -56,13 +56,13 @@ const Stacktrace& GetCurrentStacktrace(int skip_frames) {
// valid exit frame information. It will not work when a breakpoint is
// set in dart code and control is got inside 'gdb' without going through
// the runtime or native transition stub.
-void _printCurrentStacktrace() {
- const Stacktrace& stacktrace = GetCurrentStacktrace(0);
+void _printCurrentStackTrace() {
+ const StackTrace& stacktrace = GetCurrentStackTrace(0);
OS::PrintErr("=== Current Trace:\n%s===\n", stacktrace.ToCString());
}
-// Like _printCurrentStacktrace, but works in a NoSafepointScope.
-void _printCurrentStacktraceNoSafepoint() {
+// Like _printCurrentStackTrace, but works in a NoSafepointScope.
+void _printCurrentStackTraceNoSafepoint() {
StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
StackFrame* frame = frames.NextFrame();
while (frame != NULL) {
@@ -72,7 +72,7 @@ void _printCurrentStacktraceNoSafepoint() {
}
DEFINE_NATIVE_ENTRY(StackTrace_current, 0) {
- const Stacktrace& stacktrace = GetCurrentStacktrace(1);
+ const StackTrace& stacktrace = GetCurrentStackTrace(1);
return stacktrace.raw();
}
« no previous file with comments | « runtime/lib/stacktrace.h ('k') | runtime/observatory/lib/src/elements/nav/notify_exception.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698