Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: runtime/vm/simulator_dbc.cc

Issue 2572563004: Improve the casing of Stackmap and Stacktrace. (Closed)
Patch Set: Build fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/simulator_dbc.h ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include <setjmp.h> // NOLINT 5 #include <setjmp.h> // NOLINT
6 #include <stdlib.h> 6 #include <stdlib.h>
7 7
8 #include "vm/globals.h" 8 #include "vm/globals.h"
9 #if defined(TARGET_ARCH_DBC) 9 #if defined(TARGET_ARCH_DBC)
10 10
(...skipping 3715 matching lines...) Expand 10 before | Expand all | Expand 10 after
3726 sp_ = reinterpret_cast<RawObject**>(sp); 3726 sp_ = reinterpret_cast<RawObject**>(sp);
3727 fp_ = reinterpret_cast<RawObject**>(fp); 3727 fp_ = reinterpret_cast<RawObject**>(fp);
3728 3728
3729 if (pc == StubCode::RunExceptionHandler_entry()->EntryPoint()) { 3729 if (pc == StubCode::RunExceptionHandler_entry()->EntryPoint()) {
3730 // The RunExceptionHandler stub is a placeholder. We implement 3730 // The RunExceptionHandler stub is a placeholder. We implement
3731 // its behavior here. 3731 // its behavior here.
3732 RawObject* raw_exception = thread->active_exception(); 3732 RawObject* raw_exception = thread->active_exception();
3733 RawObject* raw_stacktrace = thread->active_stacktrace(); 3733 RawObject* raw_stacktrace = thread->active_stacktrace();
3734 ASSERT(raw_exception != Object::null()); 3734 ASSERT(raw_exception != Object::null());
3735 special_[kExceptionSpecialIndex] = raw_exception; 3735 special_[kExceptionSpecialIndex] = raw_exception;
3736 special_[kStacktraceSpecialIndex] = raw_stacktrace; 3736 special_[kStackTraceSpecialIndex] = raw_stacktrace;
3737 pc_ = thread->resume_pc(); 3737 pc_ = thread->resume_pc();
3738 } else if (pc == StubCode::DeoptForRewind_entry()->EntryPoint()) { 3738 } else if (pc == StubCode::DeoptForRewind_entry()->EntryPoint()) {
3739 // The DeoptForRewind stub is a placeholder. We will eventually 3739 // The DeoptForRewind stub is a placeholder. We will eventually
3740 // implement its behavior here. 3740 // implement its behavior here.
3741 // 3741 //
3742 // TODO(turnidge): Refactor the Deopt bytecode so that we can use 3742 // TODO(turnidge): Refactor the Deopt bytecode so that we can use
3743 // the implementation here too. The deopt pc is stored in 3743 // the implementation here too. The deopt pc is stored in
3744 // Thread::resume_pc(). After invoking deoptimization, we usually 3744 // Thread::resume_pc(). After invoking deoptimization, we usually
3745 // call into Debugger::RewindPostDeopt(), but I need to figure out 3745 // call into Debugger::RewindPostDeopt(), but I need to figure out
3746 // if that makes any sense (it would JumpToFrame during a 3746 // if that makes any sense (it would JumpToFrame during a
3747 // JumpToFrame, which seems wrong). 3747 // JumpToFrame, which seems wrong).
3748 UNIMPLEMENTED(); 3748 UNIMPLEMENTED();
3749 } else { 3749 } else {
3750 pc_ = pc; 3750 pc_ = pc;
3751 } 3751 }
3752 3752
3753 buf->Longjmp(); 3753 buf->Longjmp();
3754 UNREACHABLE(); 3754 UNREACHABLE();
3755 } 3755 }
3756 3756
3757 } // namespace dart 3757 } // namespace dart
3758 3758
3759 #endif // defined TARGET_ARCH_DBC 3759 #endif // defined TARGET_ARCH_DBC
OLDNEW
« no previous file with comments | « runtime/vm/simulator_dbc.h ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698