Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: runtime/vm/object_service.cc

Issue 2572563004: Improve the casing of Stackmap and Stacktrace. (Closed)
Patch Set: Build fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/object_store.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/debugger.h" 5 #include "vm/debugger.h"
6 #include "vm/disassembler.h" 6 #include "vm/disassembler.h"
7 #include "vm/object.h" 7 #include "vm/object.h"
8 #include "vm/object_store.h" 8 #include "vm/object_store.h"
9 #include "vm/stub_code.h" 9 #include "vm/stub_code.h"
10 #include "vm/symbols.h" 10 #include "vm/symbols.h"
(...skipping 691 matching lines...) Expand 10 before | Expand all | Expand 10 after
702 JSONObject jsobj(stream); 702 JSONObject jsobj(stream);
703 PrintToJSONObject(&jsobj, ref); 703 PrintToJSONObject(&jsobj, ref);
704 } 704 }
705 705
706 706
707 void CodeSourceMap::PrintJSONImpl(JSONStream* stream, bool ref) const { 707 void CodeSourceMap::PrintJSONImpl(JSONStream* stream, bool ref) const {
708 Object::PrintJSONImpl(stream, ref); 708 Object::PrintJSONImpl(stream, ref);
709 } 709 }
710 710
711 711
712 void Stackmap::PrintJSONImpl(JSONStream* stream, bool ref) const { 712 void StackMap::PrintJSONImpl(JSONStream* stream, bool ref) const {
713 Object::PrintJSONImpl(stream, ref); 713 Object::PrintJSONImpl(stream, ref);
714 } 714 }
715 715
716 716
717 void LocalVarDescriptors::PrintJSONImpl(JSONStream* stream, bool ref) const { 717 void LocalVarDescriptors::PrintJSONImpl(JSONStream* stream, bool ref) const {
718 JSONObject jsobj(stream); 718 JSONObject jsobj(stream);
719 AddCommonObjectProperties(&jsobj, "Object", ref); 719 AddCommonObjectProperties(&jsobj, "Object", ref);
720 // TODO(johnmccutchan): Generate a stable id. LocalVarDescriptors hang off 720 // TODO(johnmccutchan): Generate a stable id. LocalVarDescriptors hang off
721 // a Code object but do not have a back reference to generate an ID. 721 // a Code object but do not have a back reference to generate an ID.
722 jsobj.AddServiceId(*this); 722 jsobj.AddServiceId(*this);
(...skipping 757 matching lines...) Expand 10 before | Expand all | Expand 10 after
1480 void ClosureData::PrintJSONImpl(JSONStream* stream, bool ref) const { 1480 void ClosureData::PrintJSONImpl(JSONStream* stream, bool ref) const {
1481 Object::PrintJSONImpl(stream, ref); 1481 Object::PrintJSONImpl(stream, ref);
1482 } 1482 }
1483 1483
1484 1484
1485 void Closure::PrintJSONImpl(JSONStream* stream, bool ref) const { 1485 void Closure::PrintJSONImpl(JSONStream* stream, bool ref) const {
1486 Instance::PrintJSONImpl(stream, ref); 1486 Instance::PrintJSONImpl(stream, ref);
1487 } 1487 }
1488 1488
1489 1489
1490 void Stacktrace::PrintJSONImpl(JSONStream* stream, bool ref) const { 1490 void StackTrace::PrintJSONImpl(JSONStream* stream, bool ref) const {
1491 JSONObject jsobj(stream); 1491 JSONObject jsobj(stream);
1492 PrintSharedInstanceJSON(&jsobj, ref); 1492 PrintSharedInstanceJSON(&jsobj, ref);
1493 jsobj.AddProperty("kind", "StackTrace"); 1493 jsobj.AddProperty("kind", "StackTrace");
1494 jsobj.AddServiceId(*this); 1494 jsobj.AddServiceId(*this);
1495 intptr_t idx = 0; 1495 intptr_t idx = 0;
1496 jsobj.AddProperty("valueAsString", ToCStringInternal(&idx)); 1496 jsobj.AddProperty("valueAsString", ToCStringInternal(&idx));
1497 } 1497 }
1498 1498
1499 1499
1500 void RegExp::PrintJSONImpl(JSONStream* stream, bool ref) const { 1500 void RegExp::PrintJSONImpl(JSONStream* stream, bool ref) const {
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
1574 jsobj.AddProperty("mirrorReferent", referent_handle); 1574 jsobj.AddProperty("mirrorReferent", referent_handle);
1575 } 1575 }
1576 1576
1577 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const { 1577 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
1578 Instance::PrintJSONImpl(stream, ref); 1578 Instance::PrintJSONImpl(stream, ref);
1579 } 1579 }
1580 1580
1581 #endif 1581 #endif
1582 1582
1583 } // namespace dart 1583 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/object_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698