Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 2572563004: Improve the casing of Stackmap and Stacktrace. (Closed)
Patch Set: Build fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/dart_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl_test.cc
diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc
index 7ee03f7c9732e9d8095bc6506709f0df0163f2a3..1b26eb557cc75f00de2798a2d1aa831d6198fcf5 100644
--- a/runtime/vm/dart_api_impl_test.cc
+++ b/runtime/vm/dart_api_impl_test.cc
@@ -59,13 +59,13 @@ TEST_CASE(ErrorHandleBasics) {
EXPECT(Dart_IsError(Dart_ErrorGetException(error)));
EXPECT_VALID(Dart_ErrorGetException(exception));
- EXPECT(Dart_IsError(Dart_ErrorGetStacktrace(instance)));
- EXPECT(Dart_IsError(Dart_ErrorGetStacktrace(error)));
- EXPECT_VALID(Dart_ErrorGetStacktrace(exception));
+ EXPECT(Dart_IsError(Dart_ErrorGetStackTrace(instance)));
+ EXPECT(Dart_IsError(Dart_ErrorGetStackTrace(error)));
+ EXPECT_VALID(Dart_ErrorGetStackTrace(exception));
}
-TEST_CASE(StacktraceInfo) {
+TEST_CASE(StackTraceInfo) {
const char* kScriptChars =
"bar() => throw new Error();\n"
"foo() => bar();\n"
@@ -136,7 +136,7 @@ TEST_CASE(StacktraceInfo) {
}
-TEST_CASE(DeepStacktraceInfo) {
+TEST_CASE(DeepStackTraceInfo) {
const char* kScriptChars =
"foo(n) => n == 1 ? throw new Error() : foo(n-1);\n"
"testMain() => foo(50);\n";
@@ -156,7 +156,7 @@ TEST_CASE(DeepStacktraceInfo) {
EXPECT_EQ(51, frame_count);
// Test something bigger than the preallocated size to verify nothing was
// truncated.
- EXPECT(51 > Stacktrace::kPreallocatedStackdepth);
+ EXPECT(51 > StackTrace::kPreallocatedStackdepth);
Dart_Handle function_name;
Dart_Handle script_url;
@@ -215,7 +215,7 @@ TEST_CASE(DeepStacktraceInfo) {
}
-TEST_CASE(StackOverflowStacktraceInfo) {
+TEST_CASE(StackOverflowStackTraceInfo) {
const char* kScriptChars =
"class C {\n"
" static foo() => foo();\n"
@@ -234,7 +234,7 @@ TEST_CASE(StackOverflowStacktraceInfo) {
intptr_t frame_count = 0;
result = Dart_StackTraceLength(stacktrace, &frame_count);
EXPECT_VALID(result);
- EXPECT_EQ(Stacktrace::kPreallocatedStackdepth - 1, frame_count);
+ EXPECT_EQ(StackTrace::kPreallocatedStackdepth - 1, frame_count);
Dart_Handle function_name;
Dart_Handle script_url;
@@ -264,7 +264,7 @@ TEST_CASE(StackOverflowStacktraceInfo) {
}
-TEST_CASE(OutOfMemoryStacktraceInfo) {
+TEST_CASE(OutOfMemoryStackTraceInfo) {
const char* kScriptChars =
"var number_of_ints = 134000000;\n"
"testMain() {\n"
@@ -278,7 +278,7 @@ TEST_CASE(OutOfMemoryStacktraceInfo) {
Dart_StackTrace stacktrace;
Dart_Handle result = Dart_GetStackTraceFromError(error, &stacktrace);
- EXPECT(Dart_IsError(result)); // No Stacktrace for OutOfMemory.
+ EXPECT(Dart_IsError(result)); // No StackTrace for OutOfMemory.
}
@@ -295,7 +295,7 @@ void CurrentStackTraceNative(Dart_NativeArguments args) {
EXPECT_EQ(52, frame_count);
// Test something bigger than the preallocated size to verify nothing was
// truncated.
- EXPECT(52 > Stacktrace::kPreallocatedStackdepth);
+ EXPECT(52 > StackTrace::kPreallocatedStackdepth);
Dart_Handle function_name;
Dart_Handle script_url;
@@ -380,7 +380,7 @@ static Dart_NativeFunction CurrentStackTraceNativeLookup(
}
-TEST_CASE(CurrentStacktraceInfo) {
+TEST_CASE(CurrentStackTraceInfo) {
const char* kScriptChars =
"inspectStack() native 'CurrentStackTraceNatve';\n"
"foo(n) => n == 1 ? inspectStack() : foo(n-1);\n"
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/dart_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698