Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call sites of EmbedContentViewActivity to use
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code yet, also not sure if
we should clean the chrome strings for the titles if we don't need them.

There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.
Not sure which one should we use here.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background). Don't have
a spec so not sure if we would hide the url bar here and fix the icon
color logic.

Screen shots are attached in crbug.
BUG=673522
Committed: https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c
Cr-Commit-Position: refs/heads/master@{#439168}

[xingliu, 2016-12-12 23:22:51]

Description was changed from

==========
Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call site to use EmbedContentViewActivity to
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code, also not sure if we
should clean the chrome strings for the titles if we don't need them.


There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background).



BUG=
==========

to

==========
Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call site to use EmbedContentViewActivity to
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code, also not sure if we
should clean the chrome strings for the titles if we don't need them.


There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background).


Screen shots are attached in crbug.
BUG=673522
==========

[xingliu, 2016-12-12 23:54:20]

Description was changed from

==========
Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call site to use EmbedContentViewActivity to
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code, also not sure if we
should clean the chrome strings for the titles if we don't need them.


There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background).


Screen shots are attached in crbug.
BUG=673522
==========

to

==========
Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call sites of EmbedContentViewActivity to use
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code yet, also not sure if
we should clean the chrome strings for the titles if we don't need them.


There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background). Don't have
a spec so not sure if we would hide the url bar here.


Screen shots are attached in crbug.
BUG=673522
==========

[xingliu, 2016-12-12 23:55:10]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[xingliu, 2016-12-12 23:55:43]

xingliu@chromium.org changed reviewers:
+ dtrainor@chromium.org

[xingliu, 2016-12-12 23:55:44]

Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

[commit-bot: I haz the power, 2016-12-12 23:56:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:29:25]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-12-13 17:50:39]

Description was changed from

==========
Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call sites of EmbedContentViewActivity to use
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code yet, also not sure if
we should clean the chrome strings for the titles if we don't need them.


There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background). Don't have
a spec so not sure if we would hide the url bar here.


Screen shots are attached in crbug.
BUG=673522
==========

to

==========
Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call sites of EmbedContentViewActivity to use
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code yet, also not sure if
we should clean the chrome strings for the titles if we don't need them.


There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.
Not sure which one should we use here.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background). Don't have
a spec so not sure if we would hide the url bar here and fix the icon
color logic.


Screen shots are attached in crbug.
BUG=673522
==========

[David Trainor- moved to gerrit, 2016-12-13 19:04:36]

dtrainor@chromium.org changed reviewers:
+ tedchoc@chromium.org

[David Trainor- moved to gerrit, 2016-12-13 19:04:36]

Adding tedchoc@.  Regarding the differences, I think we're ok with adding
restricted hooks to CCT that we can use to set those variables appropriately.

[Ted C, 2016-12-13 19:25:11]

lgtm w/ some small comments

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:996:
CustomTabsIntent.Builder builder = new CustomTabsIntent.Builder();
I would do:

CustomTabsIntent cctIntent = new CustomTabsIntent.Builder()
        .setShowTitle(true)
        .setToolbarColor(getColor...)
        .build();
cctIntent.intent.setData(Uri.parse(url));

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:1002:
Intent newIntent = new Intent(builder.build().intent);
instead of these following lines, I would replace it with:

ChromeLauncherActivity.createCustomTabActivityIntent(context, intent, false);

That will handle NEW_TASK if needed.

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
(right):

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java:509:
public void showCustomTabActivity(int url) {
Instead of naming this based on the activity, I would name it on what it is
supposed to do.  showInfoPage or something.

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java
(right):

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java:78:
* Show a web page with CustomTabActivity. The page doesn't show navigation
control.
same comment, I wouldn't mention the activity type here.

[xingliu, 2016-12-13 22:07:16]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 22:07:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 22:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 22:46:05]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-12-14 17:48:43]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 17:49:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 18:20:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 18:20:21]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-12-14 18:51:26]

lgtm

[Ted C, 2016-12-14 19:01:20]

last nit

https://codereview.chromium.org/2571553003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2571553003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:1003:
.setShowTitle(true)
the indenting should be 8 from the start of the line (i.e. don't trust
clang-format for java)

[xingliu, 2016-12-14 19:50:41]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 19:51:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-12-14 20:02:08]

Thanks for the review. 

After rebase, found an issue in FRE logic in CustomTabActivity, so have to add
some more logic to fix it.

Please diff with patch 3, which is a clean rebase.

Also hide the app menu button to avoid issue in FRE.

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:996:
CustomTabsIntent.Builder builder = new CustomTabsIntent.Builder();
On 2016/12/13 19:25:11, Ted C wrote:
> I would do:
> 
> CustomTabsIntent cctIntent = new CustomTabsIntent.Builder()
>         .setShowTitle(true)
>         .setToolbarColor(getColor...)
>         .build();
> cctIntent.intent.setData(Uri.parse(url));

Done.

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:1002:
Intent newIntent = new Intent(builder.build().intent);
On 2016/12/13 19:25:11, Ted C wrote:
> instead of these following lines, I would replace it with:
> 
> ChromeLauncherActivity.createCustomTabActivityIntent(context, intent, false);
> 
> That will handle NEW_TASK if needed.
> 

Done.

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
(right):

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java:509:
public void showCustomTabActivity(int url) {
On 2016/12/13 19:25:11, Ted C wrote:
> Instead of naming this based on the activity, I would name it on what it is
> supposed to do.  showInfoPage or something.

Done.

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java
(right):

https://codereview.chromium.org/2571553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java:78:
* Show a web page with CustomTabActivity. The page doesn't show navigation
control.
On 2016/12/13 19:25:11, Ted C wrote:
> same comment, I wouldn't mention the activity type here.

Done.

[commit-bot: I haz the power, 2016-12-14 20:36:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 20:36:54]

Dry run: This issue passed the CQ dry run.

[Ted C, 2016-12-14 21:19:42]

lgtm w/ a modification to prevent anyone but chrome doing this

https://codereview.chromium.org/2571553003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2571553003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:1007:
customTabIntent.intent.putExtra(CustomTabIntentDataProvider.EXTRA_IS_INFO_PAGE,
true);
I would add this as well:
IntentHandler.addTrustedIntentExtras(intent, context);

We only want Chrome to be able to pass through FRE.

https://codereview.chromium.org/2571553003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
(right):

https://codereview.chromium.org/2571553003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:170:
mIsInfoPage = IntentUtils.safeGetBooleanExtra(intent, EXTRA_IS_INFO_PAGE,
false);
Here you'll want to add the check for mIsTrustedIntent like above

[xingliu, 2016-12-14 23:37:07]

Fixes based on review.

https://codereview.chromium.org/2571553003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2571553003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:1007:
customTabIntent.intent.putExtra(CustomTabIntentDataProvider.EXTRA_IS_INFO_PAGE,
true);
On 2016/12/14 21:19:42, Ted C wrote:
> I would add this as well:
> IntentHandler.addTrustedIntentExtras(intent, context);
> 
> We only want Chrome to be able to pass through FRE.
> 

Done, also tweaked the intent logic here a little bit,
createCustomTabActivityIntent is called earlier, so addTrustedIntentExtras can
work fast and correctly.

https://codereview.chromium.org/2571553003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
(right):

https://codereview.chromium.org/2571553003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:170:
mIsInfoPage = IntentUtils.safeGetBooleanExtra(intent, EXTRA_IS_INFO_PAGE,
false);
On 2016/12/14 21:19:42, Ted C wrote:
> Here you'll want to add the check for mIsTrustedIntent like above

Done.

[David Trainor- moved to gerrit, 2016-12-14 23:47:15]

https://codereview.chromium.org/2571553003/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
(right):

https://codereview.chromium.org/2571553003/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:177:
if (mIsInfoPage) mMenuButton.setVisibility(View.INVISIBLE);
Do we want the layout to still reserve the space for the button?

[Ted C, 2016-12-15 00:26:46]

https://codereview.chromium.org/2571553003/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
(right):

https://codereview.chromium.org/2571553003/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:177:
if (mIsInfoPage) mMenuButton.setVisibility(View.INVISIBLE);
On 2016/12/14 23:47:15, David Trainor wrote:
> Do we want the layout to still reserve the space for the button?

Oh didn't see this, I would actually keep the menu there.  It lets you reload,
go forward, get page info.

This landed and should hide the open in chrome from the menu:
https://codereview.chromium.org/2559573002/

So, I "think" the menu should only contain correct things at this point.

[xingliu, 2016-12-15 01:28:55]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 01:29:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-12-15 01:30:05]

Thanks for the review, now we keep the menu button.

The code is cleaner since logic for hiding menu button needs a work around.

https://codereview.chromium.org/2571553003/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
(right):

https://codereview.chromium.org/2571553003/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:177:
if (mIsInfoPage) mMenuButton.setVisibility(View.INVISIBLE);
On 2016/12/15 00:26:46, Ted C wrote:
> On 2016/12/14 23:47:15, David Trainor wrote:
> > Do we want the layout to still reserve the space for the button?
> 
> Oh didn't see this, I would actually keep the menu there.  It lets you reload,
> go forward, get page info.
> 
> This landed and should hide the open in chrome from the menu:
> https://codereview.chromium.org/2559573002/
> 
> So, I "think" the menu should only contain correct things at this point.

Done, keep the menu, and removed the "Open in Chrome" menu item for info page.

This CL already has that commit, it fixed the context menu, but the menu item
here comes from app menu, fixed in CustomTabAppMenuPropertiesDelegate.

Also remove other logic for hiding the menu button, looks much cleaner.

[commit-bot: I haz the power, 2016-12-15 01:37:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 01:37:17]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[xingliu, 2016-12-15 18:20:36]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 18:21:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 18:29:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 18:29:28]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-12-15 19:06:31]

lgtm % tedchoc

[Ted C, 2016-12-15 19:20:06]

lgtm w/ small comment

https://codereview.chromium.org/2571553003/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
(right):

https://codereview.chromium.org/2571553003/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java:114:
if (mIsInfoPage) {
I would just use this here: !FirstRunStatus.getFirstRunFlowComplete()

Then it is more consistent with the other call sites.

[xingliu, 2016-12-16 00:05:19]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 00:06:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-12-16 00:38:28]

Fixes based on feedback, also fix an issue for "chrome://" urls for info page.

https://codereview.chromium.org/2571553003/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
(right):

https://codereview.chromium.org/2571553003/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java:114:
if (mIsInfoPage) {
On 2016/12/15 19:20:06, Ted C wrote:
> I would just use this here: !FirstRunStatus.getFirstRunFlowComplete()
> 
> Then it is more consistent with the other call sites.

Done.

Also fix an issue for url with chrome schema.

[commit-bot: I haz the power, 2016-12-16 01:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 01:15:12]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-12-16 19:08:09]

lgtm

lgtm!

[xingliu, 2016-12-16 19:19:22]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2016-12-16 19:19:23]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2571553003/#ps180001
(title: "Fix an issue for url with chrome schema.")

[commit-bot: I haz the power, 2016-12-16 19:20:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 19:35:44]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1481915962612420,
"parent_rev": "acc6ebeb213130b2a516747cc0f3a80947094973", "commit_rev":
"3d56c940d11ccdf02bd8d95a4a64aa7c5c6564e4"}

[commit-bot: I haz the power, 2016-12-16 19:36:10]

Description was changed from

==========
Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call sites of EmbedContentViewActivity to use
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code yet, also not sure if
we should clean the chrome strings for the titles if we don't need them.


There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.
Not sure which one should we use here.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background). Don't have
a spec so not sure if we would hide the url bar here and fix the icon
color logic.


Screen shots are attached in crbug.
BUG=673522
==========

to

==========
Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call sites of EmbedContentViewActivity to use
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code yet, also not sure if
we should clean the chrome strings for the titles if we don't need them.


There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.
Not sure which one should we use here.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background). Don't have
a spec so not sure if we would hide the url bar here and fix the icon
color logic.


Screen shots are attached in crbug.
BUG=673522

Review-Url: https://codereview.chromium.org/2571553003
==========

[commit-bot: I haz the power, 2016-12-16 19:36:12]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-12-16 19:38:24]

Description was changed from

==========
Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call sites of EmbedContentViewActivity to use
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code yet, also not sure if
we should clean the chrome strings for the titles if we don't need them.


There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.
Not sure which one should we use here.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background). Don't have
a spec so not sure if we would hide the url bar here and fix the icon
color logic.


Screen shots are attached in crbug.
BUG=673522

Review-Url: https://codereview.chromium.org/2571553003
==========

to

==========
Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call sites of EmbedContentViewActivity to use
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code yet, also not sure if
we should clean the chrome strings for the titles if we don't need them.

There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.
Not sure which one should we use here.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background). Don't have
a spec so not sure if we would hide the url bar here and fix the icon
color logic.

Screen shots are attached in crbug.
BUG=673522

Committed: https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c
Cr-Commit-Position: refs/heads/master@{#439168}
==========

[commit-bot: I haz the power, 2016-12-16 19:38:26]

Patchset 10 (id:??) landed as
https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c
Cr-Commit-Position: refs/heads/master@{#439168}