chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java - Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java

Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity. (Closed)

Patch Set: Fix an issue for url with chrome schema. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java

index 7bb495f02be4bb4da9c1314c9ec0c5482c03a478..ff536fdbbd2ccfcf1544cef9b786fe3048b83076 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java

@@ -13,7 +13,7 @@ import android.view.View.OnClickListener;

import android.widget.TextView;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.EmbedContentViewActivity;

+import org.chromium.chrome.browser.customtabs.CustomTabActivity;

/**

* A preference that navigates to an URL.

@@ -36,7 +36,7 @@ public class HyperlinkPreference extends Preference {

@Override

protected void onClick() {

- EmbedContentViewActivity.show(getContext(), mTitleResId, mUrlResId);

+ CustomTabActivity.showInfoPage(getContext(), getContext().getString(mUrlResId));

}

@Override