chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java - Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java

Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity. (Closed)

Patch Set: Fix an issue for url with chrome schema. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java

index 9e03c148da7d480b14f087e5b4ebd5f5340ee2ad..889515c0fa31e4a0b1f21a7c2869159d097b9ae8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java

@@ -17,7 +17,7 @@ import android.widget.TextView;

import org.chromium.base.CommandLine;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeSwitches;

-import org.chromium.chrome.browser.EmbedContentViewActivity;

+import org.chromium.chrome.browser.customtabs.CustomTabActivity;

import org.chromium.ui.text.NoUnderlineClickableSpan;

import org.chromium.ui.text.SpanApplier;

import org.chromium.ui.text.SpanApplier.SpanInfo;

@@ -40,15 +40,15 @@ public class LightweightFirstRunActivity extends FirstRunActivity {

NoUnderlineClickableSpan clickableTermsSpan = new NoUnderlineClickableSpan() {

@Override

public void onClick(View widget) {

- EmbedContentViewActivity.show(LightweightFirstRunActivity.this,

- R.string.terms_of_service_title, R.string.chrome_terms_of_service_url);

+ CustomTabActivity.showInfoPage(LightweightFirstRunActivity.this,

+ getString(R.string.chrome_terms_of_service_url));

}

};

NoUnderlineClickableSpan clickablePrivacySpan = new NoUnderlineClickableSpan() {

@Override

public void onClick(View widget) {

- EmbedContentViewActivity.show(LightweightFirstRunActivity.this,

- R.string.privacy_notice_title, R.string.chrome_privacy_notice_url);

+ CustomTabActivity.showInfoPage(LightweightFirstRunActivity.this,

+ getString(R.string.chrome_privacy_notice_url));

}

};

((TextView) findViewById(R.id.lightweight_fre_tos_and_privacy))