chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java - Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity. (Closed)

Patch Set: Fix an issue for url with chrome schema. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

index 9b4b03be42caab335e929cc2b48d751d543eabe4..dc79c4122ba1f3b992a9a5cbe9bc358f73583b9a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

@@ -20,7 +20,7 @@ import org.chromium.base.library_loader.ProcessInitException;

import org.chromium.base.metrics.CachedMetrics.EnumeratedHistogramSample;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeApplication;

-import org.chromium.chrome.browser.EmbedContentViewActivity;

+import org.chromium.chrome.browser.customtabs.CustomTabActivity;

import org.chromium.chrome.browser.customtabs.CustomTabsConnection;

import org.chromium.chrome.browser.document.ChromeLauncherActivity;

import org.chromium.chrome.browser.init.ChromeBrowserInitializer;

@@ -546,7 +546,7 @@ public class FirstRunActivity extends AppCompatActivity implements FirstRunPageD

}

@Override

- public void showEmbedContentViewActivity(int title, int url) {

- EmbedContentViewActivity.show(this, title, url);

+ public void showInfoPage(int url) {

+ CustomTabActivity.showInfoPage(this, getString(url));

}